RESOLVED FIXED Bug 117376
fourthTier: Recursive deadlock in DFG::ByteCodeParser 
https://bugs.webkit.org/show_bug.cgi?id=117376
Summary fourthTier: Recursive deadlock in DFG::ByteCodeParser
Filip Pizlo
Reported 2013-06-08 18:17:33 PDT
Patch forthcoming. <rdar://problem/14101274>
Attachments
the patch (3.26 KB, patch)
2013-06-08 18:19 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-06-08 18:19:05 PDT
Created attachment 204105 [details] the patch
Mark Hahnenberg
Comment 2 2013-06-08 18:37:15 PDT
Comment on attachment 204105 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review r=me > Source/WTF/ChangeLog:8 > + I've often wanted to leave a lock early. Now I have that power! Yay!
Darin Adler
Comment 3 2013-06-08 18:46:22 PDT
Comment on attachment 204105 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review > Source/WTF/wtf/Locker.h:39 > + Locker(T& lockable) : m_lockable(&lockable) { lock(); } > + Locker(T* lockable) : m_lockable(lockable) { lock(); } I think these ought to say explicit.
Filip Pizlo
Comment 4 2013-06-08 18:57:07 PDT
(In reply to comment #3) > (From update of attachment 204105 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review > > > Source/WTF/wtf/Locker.h:39 > > + Locker(T& lockable) : m_lockable(&lockable) { lock(); } > > + Locker(T* lockable) : m_lockable(lockable) { lock(); } > > I think these ought to say explicit. Yes. Will change.
Filip Pizlo
Comment 5 2013-06-08 22:41:35 PDT
Landed in http://trac.webkit.org/changeset/151352
Note You need to log in before you can comment on or make changes to this bug.