Bug 117376 - fourthTier: Recursive deadlock in DFG::ByteCodeParser
Summary: fourthTier: Recursive deadlock in DFG::ByteCodeParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-06-08 18:17 PDT by Filip Pizlo
Modified: 2013-06-08 22:41 PDT (History)
7 users (show)

See Also:


Attachments
the patch (3.26 KB, patch)
2013-06-08 18:19 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-06-08 18:17:33 PDT
Patch forthcoming.

<rdar://problem/14101274>
Comment 1 Filip Pizlo 2013-06-08 18:19:05 PDT
Created attachment 204105 [details]
the patch
Comment 2 Mark Hahnenberg 2013-06-08 18:37:15 PDT
Comment on attachment 204105 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review

r=me

> Source/WTF/ChangeLog:8
> +        I've often wanted to leave a lock early. Now I have that power!

Yay!
Comment 3 Darin Adler 2013-06-08 18:46:22 PDT
Comment on attachment 204105 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review

> Source/WTF/wtf/Locker.h:39
> +    Locker(T& lockable) : m_lockable(&lockable) { lock(); }
> +    Locker(T* lockable) : m_lockable(lockable) { lock(); }

I think these ought to say explicit.
Comment 4 Filip Pizlo 2013-06-08 18:57:07 PDT
(In reply to comment #3)
> (From update of attachment 204105 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204105&action=review
> 
> > Source/WTF/wtf/Locker.h:39
> > +    Locker(T& lockable) : m_lockable(&lockable) { lock(); }
> > +    Locker(T* lockable) : m_lockable(lockable) { lock(); }
> 
> I think these ought to say explicit.

Yes.  Will change.
Comment 5 Filip Pizlo 2013-06-08 22:41:35 PDT
Landed in http://trac.webkit.org/changeset/151352