Bug 117366 - isContravenedByStructure is backwards
Summary: isContravenedByStructure is backwards
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-07 17:02 PDT by Mark Hahnenberg
Modified: 2013-06-11 13:53 PDT (History)
0 users

See Also:


Attachments
Patch (1.38 KB, patch)
2013-06-07 17:03 PDT, Mark Hahnenberg
fpizlo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2013-06-07 17:02:14 PDT
We should be checking if arrayModeForStructure(structure) is a subset of arrayModesThatPassFiltering(), not the other way around.
Comment 1 Mark Hahnenberg 2013-06-07 17:03:22 PDT
Created attachment 204075 [details]
Patch
Comment 2 Filip Pizlo 2013-06-07 17:10:31 PDT
Comment on attachment 204075 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204075&action=review

> Source/JavaScriptCore/dfg/DFGArrayMode.h:366
>      bool isContravenedByStructure(Structure* structure)

Can we make it clearer that the thing that was proven was the structure?

What about having a method called: structureWouldPassArrayModeFiltering(Structure*)

RS=me to make a change like that
Comment 3 Mark Hahnenberg 2013-06-11 13:53:42 PDT
Committed r151468: <http://trac.webkit.org/changeset/151468>