Bug 117363 - fourthTier: don't insert ForceOSRExits except for inadequate coverage
Summary: fourthTier: don't insert ForceOSRExits except for inadequate coverage
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Reported: 2013-06-07 15:24 PDT by Filip Pizlo
Modified: 2013-09-20 12:21 PDT (History)
7 users (show)

See Also:

work in progress (22.04 KB, patch)
2013-06-07 15:26 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (29.14 KB, patch)
2013-06-07 15:49 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-06-07 15:24:19 PDT
Previously (in http://trac.webkit.org/changeset/151303) I made it so that we inserted ForceOSRExits more eagerly.  I now think it's better to have contradictions execute normally and exit with full OSR exit profiling.  It's better at catching the few cases where the DFG will end up with different types than the baseline engines.
Comment 1 Filip Pizlo 2013-06-07 15:26:32 PDT
Created attachment 204071 [details]
work in progress
Comment 2 Filip Pizlo 2013-06-07 15:49:10 PDT
Created attachment 204072 [details]
the patch
Comment 3 Mark Hahnenberg 2013-06-07 16:01:42 PDT
Comment on attachment 204072 [details]
the patch

Comment 4 Filip Pizlo 2013-06-07 17:06:16 PDT
Landed in http://trac.webkit.org/changeset/151343
Comment 5 Oliver Hunt 2013-09-20 12:21:47 PDT
This is leading to crashes on iCloud.com :(