Bug 117346 - Get rid of outdated getter / setter raises from Web IDL
Summary: Get rid of outdated getter / setter raises from Web IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-07 07:09 PDT by Chris Dumez
Modified: 2013-06-07 08:34 PDT (History)
6 users (show)

See Also:


Attachments
Patch (76.47 KB, patch)
2013-06-07 07:25 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-07 07:09:26 PDT
Web IDL no longer specifies exceptions for attribute getters / setters and this is only explained in prose. WebKit still needs to know that an exception can be raised though (to add ExceptionCode argument) so we should have WebKit-specific IDL extended attributes:
GetterRaisesException / SetterRaisesException (naming is consistent with Blink).
Comment 1 Chris Dumez 2013-06-07 07:25:09 PDT
Created attachment 204043 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-07 08:32:39 PDT
Comment on attachment 204043 [details]
Patch

Clearing flags on attachment: 204043

Committed r151321: <http://trac.webkit.org/changeset/151321>
Comment 3 WebKit Commit Bot 2013-06-07 08:32:42 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Chris Dumez 2013-06-07 08:34:54 PDT
Updated the WebKit IDL wiki accordingly in:
http://trac.webkit.org/wiki/WebKitIDL?action=diff&version=122&old_version=121