Bug 117344 – [curl] Allow headers with empty value

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Peter Gal]

The current usage of the curl backend does not allow headers with empty value. This can be easily fixed just a simple quotes ("") as value instead of an empty string will tell curl that we want it as an empty value.

[Peter Gal]

Created attachment 204036 [details]
patch

[Peter Gal]

Comment on attachment 204036 [details]
patch

soo... it seems this is not my day it seems curl doesn't do what it says on it's own documentation page. But still with that patch some test cases passed :)

I'll deliver a better patch.

[Peter Gal]

Created attachment 204041 [details]
fixed patch

Not this'll work as intended.

[Kenneth Rohde Christiansen]

Comment on attachment 204041 [details]
fixed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204041&action=review

> Source/WebCore/ChangeLog:11
> +        No new tests, alread covered by:
> +        http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
> +        http/tests/xmlhttprequest/post-blob-content-type-sync.html
> +

no updated results?

> Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:758
> +                // insert the ; to tell curl that this header has an empty value

Nit: Use real sentences: "Insert" and punctuation mark at end.

[Peter Gal]

(In reply to comment #4)
> (From update of attachment 204041 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=204041&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        No new tests, alread covered by:
> > +        http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-value.html
> > +        http/tests/xmlhttprequest/post-blob-content-type-sync.html
> > +
> 
> no updated results?

No need for that. With this patch the test executes as expected.

> 
> > Source/WebCore/platform/network/curl/ResourceHandleManager.cpp:758
> > +                // insert the ; to tell curl that this header has an empty value
> 
> Nit: Use real sentences: "Insert" and punctuation mark at end.

Okay, will post the update in a minute.

[Peter Gal]

Created attachment 204088 [details]
patch with fixes

updated the patch based on the previous comment.

[Brent Fulgham]

Comment on attachment 204088 [details]
patch with fixes

r=me.

[WebKit Commit Bot]

Comment on attachment 204088 [details]
patch with fixes

Clearing flags on attachment: 204088

Committed r151348: <http://trac.webkit.org/changeset/151348>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.