Update window-property.html test cases for Device Proximity Event. The global constructors are no longer enumerable after r149001.
Created attachment 204032 [details] Patch
Comment on attachment 204032 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204032&action=review The change is correct. Why doesn't it unskip the test for any port? > LayoutTests/proximity/window-property.html:-20 > -shouldBeTrue("hasDeviceProximityEventProperty()"); hasDeviceProximityEventProperty function above can be removed as well.
Device Proximity Event is not enabled yet on the all port. I will enable this on the efl soon. And I will remove "shouldBeTrue("hasDeviceProximityEventProperty()");" also.
Created attachment 204035 [details] Patch
Comment on attachment 204035 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=204035&action=review Sorry this is not what I meant. > LayoutTests/proximity/window-property.html:20 > +shouldBeFalse("window.propertyIsEnumerable('DeviceProximityEvent')"); This change is OK. However, the hasDeviceProximityEventProperty() function 10 lines above should be removed as well and it is likely not used anymore. > LayoutTests/proximity/window-property.html:-34 > -shouldBeTrue("hasOnDeviceProximityProperty()"); This is unrelated and should stay.
Created attachment 204038 [details] Patch
Comment on attachment 204038 [details] Patch Looks good, thanks. r=me.
Comment on attachment 204038 [details] Patch Clearing flags on attachment: 204038 Committed r151317: <http://trac.webkit.org/changeset/151317>
All reviewed patches have been landed. Closing bug.