Bug 117335 - [EFL][GTK] TextCheckerEnchant uses deprecated enchant_dict_add_to_personal
Summary: [EFL][GTK] TextCheckerEnchant uses deprecated enchant_dict_add_to_personal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Grzegorz Czajkowski
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-07 02:07 PDT by Grzegorz Czajkowski
Modified: 2013-06-07 06:36 PDT (History)
6 users (show)

See Also:

Attachments
proposed patch (1.67 KB, patch)
2013-06-07 02:11 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2013-06-07 02:07:39 PDT 
enchant_dict_add_to_personal has been deprecated at r22321 in Enchant repository.
We should call enchant_dict_add instead of enchant_dict_add_to_personal.
Comment 1 Grzegorz Czajkowski 2013-06-07 02:11:28 PDT 
Created attachment 204018 [details]
proposed patch
Comment 2 Mario Sanchez Prada 2013-06-07 03:26:38 PDT 
Comment on attachment 204018 [details]
proposed patch

Indeed it seems this function has been deprecated already a long time ago in favor of enchant_dict_add(). Thus, no objections at all

Thanks for the patch
Comment 3 Chris Dumez 2013-06-07 06:11:48 PDT 
Comment on attachment 204018 [details]
proposed patch

Thanks for informal review Mario. r=me.
Comment 4 WebKit Commit Bot 2013-06-07 06:36:27 PDT 
Comment on attachment 204018 [details]
proposed patch

Clearing flags on attachment: 204018

Committed r151316: <http://trac.webkit.org/changeset/151316>
Comment 5 WebKit Commit Bot 2013-06-07 06:36:30 PDT 
All reviewed patches have been landed.  Closing bug.