Bug 117332 - [GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_style' should be allowed to be NULL
Summary: [GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_comp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-06 23:37 PDT by Diego Pino
Modified: 2013-06-12 01:09 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.21 KB, patch)
2013-06-06 23:45 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2013-06-06 23:37:10 PDT
According to the 'Document Object Model' CSS spec:

http://www.w3.org/TR/DOM-Level-2-Style/css.html

Parameter 'pseudoElement' from function 'getComputedStyle' could be null. The GObject binding generator generates code that always check this parameter cannot be null.
Comment 1 Diego Pino 2013-06-06 23:45:58 PDT
Created attachment 204004 [details]
Patch
Comment 2 Xan Lopez 2013-06-12 00:46:51 PDT
Comment on attachment 204004 [details]
Patch

Looks good in general. It's a bit sad to duplicate some of the setup code but the existing one seems pretty specific to the test that uses it.
Comment 3 WebKit Commit Bot 2013-06-12 01:09:55 PDT
Comment on attachment 204004 [details]
Patch

Clearing flags on attachment: 204004

Committed r151489: <http://trac.webkit.org/changeset/151489>
Comment 4 WebKit Commit Bot 2013-06-12 01:09:58 PDT
All reviewed patches have been landed.  Closing bug.