Bug 117321 - [Qt] Simulate delay in QWebKitTest::touchTap()
Summary: [Qt] Simulate delay in QWebKitTest::touchTap()
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-06-06 14:57 PDT by Lamarque V. Souza
Modified: 2014-02-03 03:26 PST (History)
5 users (show)

See Also:

Patch (1.64 KB, patch)
2013-06-06 15:11 PDT, Lamarque V. Souza
no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2013-06-06 16:25 PDT, Lamarque V. Souza
no flags Details | Formatted Diff | Diff
Patch (2.89 KB, patch)
2013-06-07 06:27 PDT, Lamarque V. Souza
lamarque: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lamarque V. Souza 2013-06-06 14:57:22 PDT
QWebKitTest::touchTap() contains this FIXME "implement delay using QTest::qWait() or similar." We can use QWaitCondition to implement the delay. I will submit a patch for that.
Comment 1 Lamarque V. Souza 2013-06-06 15:11:57 PDT
Created attachment 203972 [details]

Proposed patch
Comment 2 Lamarque V. Souza 2013-06-06 16:25:04 PDT
Created attachment 203978 [details]

Wait on positive delay value only.
Comment 3 Lamarque V. Souza 2013-06-07 06:27:38 PDT
Created attachment 204037 [details]

Change 'delay' parameter to 'delayInMilliseconds' for clarity.
Comment 4 Anders Carlsson 2013-10-02 21:32:46 PDT
Comment on attachment 204037 [details]

Qt has been removed, clearing review flags.
Comment 5 Jocelyn Turcotte 2014-02-03 03:26:03 PST
=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.