Bug 117303 - [GTK] Parameter 'refChild' from function 'webkit_dom_node_insert_before' should be allowed to be NULL
Summary: [GTK] Parameter 'refChild' from function 'webkit_dom_node_insert_before' shou...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-06 08:42 PDT by Diego Pino
Modified: 2013-06-06 13:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.46 KB, patch)
2013-06-06 08:51 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2013-06-06 08:42:45 PDT 
According to the spec, parameter 'refChild' from insertBefore can be null. 

http://www.w3.org/TR/DOM-Level-2-Core/core.html

However, the GObject DOM bindings generator generates code that don't allow this parameter to be NULL.
Comment 1 Diego Pino 2013-06-06 08:51:21 PDT 
Created attachment 203938 [details]
Patch
Comment 2 Xan Lopez 2013-06-06 13:21:02 PDT 
Comment on attachment 203938 [details]
Patch

Awesome!
Comment 3 WebKit Commit Bot 2013-06-06 13:43:35 PDT 
Comment on attachment 203938 [details]
Patch

Clearing flags on attachment: 203938

Committed r151288: <http://trac.webkit.org/changeset/151288>
Comment 4 WebKit Commit Bot 2013-06-06 13:43:37 PDT 
All reviewed patches have been landed.  Closing bug.