Bug 117298 - [EFL][WK2] Implement customContextMenuItemSelected
Summary: [EFL][WK2] Implement customContextMenuItemSelected
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michal Pakula vel Rutka
Depends on:
Blocks: 116601
  Show dependency treegraph
Reported: 2013-06-06 07:46 PDT by Michal Pakula vel Rutka
Modified: 2013-06-07 04:20 PDT (History)
7 users (show)

See Also:

proposed patch (5.47 KB, patch)
2013-06-07 01:53 PDT, Michal Pakula vel Rutka
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
fixed patch (5.44 KB, patch)
2013-06-07 02:08 PDT, Michal Pakula vel Rutka
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michal Pakula vel Rutka 2013-06-06 07:46:10 PDT
Currently, when custom context menu item is selected, application is not informed.
Comment 1 Michal Pakula vel Rutka 2013-06-07 01:53:37 PDT
Created attachment 204015 [details]
proposed patch
Comment 2 EFL EWS Bot 2013-06-07 01:58:11 PDT
Comment on attachment 204015 [details]
proposed patch

Attachment 204015 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/695795
Comment 3 Michal Pakula vel Rutka 2013-06-07 02:08:45 PDT
Created attachment 204017 [details]
fixed patch
Comment 4 Chris Dumez 2013-06-07 03:31:47 PDT
Comment on attachment 204017 [details]
fixed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=204017&action=review

> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:838
> +    OwnPtr<EwkContextMenuItem> item = EwkContextMenuItem::create(contextMenuItem, 0);

Wouldn't it be nicer to provide the existing EwkContextMenuItem object instead of creating a new one? I guess we can retrieve the existing one from m_contextMenu somehow.
Comment 5 Chris Dumez 2013-06-07 03:51:41 PDT
Comment on attachment 204017 [details]
fixed patch

Ok, r=me after discussing this offline. Figuring out the ewk item from the WK one is not trivial.
Comment 6 WebKit Commit Bot 2013-06-07 04:20:17 PDT
Comment on attachment 204017 [details]
fixed patch

Clearing flags on attachment: 204017

Committed r151313: <http://trac.webkit.org/changeset/151313>
Comment 7 WebKit Commit Bot 2013-06-07 04:20:20 PDT
All reviewed patches have been landed.  Closing bug.