Bug 117278 – REGRESSION (r151088): Crash navigating away from non-loaded main resources with non-loaded scripts.

• Status: CLOSED
• Resolution: FIXED
• Component: Page Loading

[Chris Petersen]

Crash occurs at WebCore::Document::haveStylesheetsLoaded() when attempting to load a page. I have seen this crash on the last few webkit nightly builds. I have started to type partial URL in the address field and it autocompletes the rest of URL. When I attempt to load the URL and go to that page, it crashes. I need to find a way to reproduce it. Here is the crash log information for now.

[Chris Petersen]

I have been seeming this problem in the last few webkit builds but this crash that happened was encountered with Webkit Nightly  r151221.

[Brady Eidson]

You forgot to attach the crash log info!  :)

[Chris Petersen]

Created attachment 203892 [details]
Crash log.txt

Added crash log for real..

[Chris Petersen]

Oops. It's there now.

[Brady Eidson]

We have this in radar - <rdar://problem/14052886>

We have steps to reproduce there, but may only be applicable internally.

[Chris Petersen]

Sweet.... I finally have reproducible steps. It's timing based for me but at least I have confidence I can reproduce it in the latest Webkit Nightly build : r151260

1) Launch Webkit Nightly r151260 on a clean install
2) After default webkit page loads ( http://nightly.webkit.org/start/trunk/151260 ), type www.macnn.com. Press return key
3) After Macnn page loads, click the back button so that it navigates back
4) IMPORTANT: After webkit page displays, click forward then back button multiple times ( 5 -7 ) in row so you switch between these two page in quick succession  ( so that progress indicator in Address bar NEVER finishes loading either page )

[Brady Eidson]

Easy to reproduce this rapidly refreshing espn.go.com  (Just hold cmd-R)

[Brady Eidson]

A null-check of document will be the fix.

I have a reduction that can reproduce this 100% reliably, and it's good enough to be a layout test.

The reduction is basically a long-loading page (main resource never finishes loading) that is waiting for an external script to load (long running script load that never finishes loading), and then refresh it once.

[Brady Eidson]

Created attachment 204065 [details]
Patch v1 - Fix + test

[Brady Eidson]

http://trac.webkit.org/changeset/151335

[Lucas Forschler]

<rdar://problem/14052886>

[Chris Petersen]

Verified fixed in Webkit NB r151344 on Mac OS X 10.8.3.

[Chris Petersen]

Closing