WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
CLOSED FIXED
117278
REGRESSION (
r151088
): Crash navigating away from non-loaded main resources with non-loaded scripts.
https://bugs.webkit.org/show_bug.cgi?id=117278
Summary
REGRESSION (r151088): Crash navigating away from non-loaded main resources wi...
Chris Petersen
Reported
2013-06-05 16:06:49 PDT
Crash occurs at WebCore::Document::haveStylesheetsLoaded() when attempting to load a page. I have seen this crash on the last few webkit nightly builds. I have started to type partial URL in the address field and it autocompletes the rest of URL. When I attempt to load the URL and go to that page, it crashes. I need to find a way to reproduce it. Here is the crash log information for now.
Attachments
Crash log.txt
(71.68 KB, text/plain)
2013-06-05 16:12 PDT
,
Chris Petersen
no flags
Details
Patch v1 - Fix + test
(3.81 KB, patch)
2013-06-07 13:48 PDT
,
Brady Eidson
andersca
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Petersen
Comment 1
2013-06-05 16:09:18 PDT
I have been seeming this problem in the last few webkit builds but this crash that happened was encountered with Webkit Nightly
r151221
.
Brady Eidson
Comment 2
2013-06-05 16:10:30 PDT
You forgot to attach the crash log info! :)
Chris Petersen
Comment 3
2013-06-05 16:12:39 PDT
Created
attachment 203892
[details]
Crash log.txt Added crash log for real..
Chris Petersen
Comment 4
2013-06-05 16:13:14 PDT
Oops. It's there now.
Brady Eidson
Comment 5
2013-06-05 16:20:57 PDT
We have this in radar - <
rdar://problem/14052886
> We have steps to reproduce there, but may only be applicable internally.
Chris Petersen
Comment 6
2013-06-06 12:16:08 PDT
Sweet.... I finally have reproducible steps. It's timing based for me but at least I have confidence I can reproduce it in the latest Webkit Nightly build :
r151260
1) Launch Webkit Nightly
r151260
on a clean install 2) After default webkit page loads (
http://nightly.webkit.org/start/trunk/151260
), type www.macnn.com. Press return key 3) After Macnn page loads, click the back button so that it navigates back 4) IMPORTANT: After webkit page displays, click forward then back button multiple times ( 5 -7 ) in row so you switch between these two page in quick succession ( so that progress indicator in Address bar NEVER finishes loading either page )
Brady Eidson
Comment 7
2013-06-07 11:39:46 PDT
Easy to reproduce this rapidly refreshing espn.go.com (Just hold cmd-R)
Brady Eidson
Comment 8
2013-06-07 12:05:33 PDT
A null-check of document will be the fix. I have a reduction that can reproduce this 100% reliably, and it's good enough to be a layout test. The reduction is basically a long-loading page (main resource never finishes loading) that is waiting for an external script to load (long running script load that never finishes loading), and then refresh it once.
Brady Eidson
Comment 9
2013-06-07 13:48:07 PDT
Created
attachment 204065
[details]
Patch v1 - Fix + test
Brady Eidson
Comment 10
2013-06-07 13:53:13 PDT
http://trac.webkit.org/changeset/151335
Lucas Forschler
Comment 11
2013-06-07 14:29:35 PDT
<
rdar://problem/14052886
>
Chris Petersen
Comment 12
2013-06-08 08:01:00 PDT
Verified fixed in Webkit NB
r151344
on Mac OS X 10.8.3.
Chris Petersen
Comment 13
2013-06-08 08:01:26 PDT
Closing
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug