Bug 117274 - Crash if an IPC connection is invalidated before it's completely set up
Summary: Crash if an IPC connection is invalidated before it's completely set up
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 13:28 PDT by Anders Carlsson
Modified: 2013-06-05 15:54 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.00 KB, patch)
2013-06-05 15:33 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (4.36 KB, patch)
2013-06-05 15:40 PDT, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-06-05 13:28:07 PDT
Crash if an IPC connection is invalidated before it's completely set up
Comment 1 Anders Carlsson 2013-06-05 15:33:47 PDT
Created attachment 203889 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-05 15:35:50 PDT
Attachment 203889 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp']" exit_code: 1
Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp:160:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2013-06-05 15:40:07 PDT
Created attachment 203891 [details]
Patch
Comment 4 WebKit Commit Bot 2013-06-05 15:42:05 PDT
Attachment 203891 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp']" exit_code: 1
Source/WebKit2/Platform/CoreIPC/mac/ConnectionMac.cpp:164:  Missing space before {  [whitespace/braces] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2013-06-05 15:43:58 PDT
Comment on attachment 203891 [details]
Patch

Quite clever. r=me
Comment 6 Anders Carlsson 2013-06-05 15:54:29 PDT
Committed r151246: <http://trac.webkit.org/changeset/151246>