Bug 117271 - [BlackBerry] Make image clickable when it has anchor as parent node.
Summary: [BlackBerry] Make image clickable when it has anchor as parent node.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 12:37 PDT by Tiancheng Jiang
Modified: 2013-06-05 14:40 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.67 KB, patch)
2013-06-05 13:08 PDT, Tiancheng Jiang
no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2013-06-05 13:33 PDT, Tiancheng Jiang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tiancheng Jiang 2013-06-05 12:37:30 PDT
Make the image click-able when it has anchor as parent. Although to check all the ancestors would be safe but it is too expensive. We will consider that later.
Comment 1 Tiancheng Jiang 2013-06-05 13:08:01 PDT
Created attachment 203876 [details]
Patch
Comment 2 Rob Buis 2013-06-05 13:13:42 PDT
Comment on attachment 203876 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203876&action=review

> Source/WebKit/blackberry/WebKitSupport/FatFingers.cpp:96
> +        || (element->hasTagName(HTMLNames::imgTag) && element->parentNode()->hasTagName(HTMLNames::aTag)))

Is it possible for parentNode to be null here?
Comment 3 Tiancheng Jiang 2013-06-05 13:33:30 PDT
Created attachment 203878 [details]
Patch
Comment 4 Rob Buis 2013-06-05 13:58:35 PDT
Comment on attachment 203878 [details]
Patch

LGTM.
Comment 5 WebKit Commit Bot 2013-06-05 14:40:17 PDT
Comment on attachment 203878 [details]
Patch

Clearing flags on attachment: 203878

Committed r151240: <http://trac.webkit.org/changeset/151240>
Comment 6 WebKit Commit Bot 2013-06-05 14:40:19 PDT
All reviewed patches have been landed.  Closing bug.