The following constructor attributes on WorkerContext interface have custom getters but their custom code doesn't seem to do anything special: [Conditional=CHANNEL_MESSAGING, CustomGetter] attribute MessageChannelConstructor MessageChannel; [CustomGetter] attribute EventSourceConstructor EventSource; [CustomGetter] attribute XMLHttpRequestConstructor XMLHttpRequest; [CustomGetter] attribute WebSocketConstructor WebSocket; We can probably remove the custom code and have them automatically generated.
Created attachment 203802 [details] WIP patch
Created attachment 203803 [details] JSWebContext.cpp diff
Created attachment 203808 [details] Patch
Comment on attachment 203808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203808&action=review Great improvement. > Source/WebCore/dom/MessageChannel.idl:29 > + Conditional=CHANNEL_MESSAGING, I wonder why MessageChannel code has been working without this conditional.
Comment on attachment 203808 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203808&action=review >> Source/WebCore/dom/MessageChannel.idl:29 >> + Conditional=CHANNEL_MESSAGING, > > I wonder why MessageChannel code has been working without this conditional. Looks like everyone is enabling CHANNEL_MESSAGING: Tools/Scripts/webkitperl/FeatureList.pm: define => "ENABLE_CHANNEL_MESSAGING", default => 1, value => \$channelMessagingSupport },
Comment on attachment 203808 [details] Patch ok, thanks for the clarification.
Comment on attachment 203808 [details] Patch Clearing flags on attachment: 203808 Committed r151223: <http://trac.webkit.org/changeset/151223>
All reviewed patches have been landed. Closing bug.