RESOLVED FIXED 117244
Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present. 
https://bugs.webkit.org/show_bug.cgi?id=117244
Summary Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
Raphael Kubo da Costa (:rakuco)
Reported 2013-06-05 04:20:29 PDT
Use WEBKITOUTPUTDIR if WEBKIT_OUTPUTDIR is not present.
Attachments
Patch (1.61 KB, patch)
2013-06-05 04:22 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.81 KB, patch)
2013-06-05 05:32 PDT, Raphael Kubo da Costa (:rakuco) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Raphael Kubo da Costa (:rakuco)
Comment 1 2013-06-05 04:22:26 PDT
Created attachment 203799 [details] Patch
Daniel Bates
Comment 2 2013-06-05 05:21:44 PDT
Comment on attachment 203799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review > Tools/Scripts/webkitdirs.pm:188 > + $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir; I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL and add a FIXME comment to the code that references the bug and explains that we should remove this line once GTK+ and EFL builds have transitioned to WEBKIT_OUTPUTDIR.
Raphael Kubo da Costa (:rakuco)
Comment 3 2013-06-05 05:32:07 PDT
Created attachment 203810 [details] Patch for landing
Raphael Kubo da Costa (:rakuco)
Comment 4 2013-06-05 05:32:20 PDT
(In reply to comment #2) > (From update of attachment 203799 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203799&action=review > > > Tools/Scripts/webkitdirs.pm:188 > > + $baseProductDir = $ENV{"WEBKITOUTPUTDIR"} if not $baseProductDir; > > I suggest we file a bug to remove support for WEBKITOUTPUTDIR for GTK+ and EFL and add a FIXME comment to the code that references the bug and explains that we should remove this line once GTK+ and EFL builds have transitioned to WEBKIT_OUTPUTDIR. Done: https://bugs.webkit.org/show_bug.cgi?id=117249
Raphael Kubo da Costa (:rakuco)
Comment 5 2013-06-05 05:35:54 PDT
Landed in <https://trac.webkit.org/r151216>.
Note You need to log in before you can comment on or make changes to this bug.