Bug 117232 - [Threaded Compositor] Apply scroll-offset and scale in Widget window coordinate.
Summary: [Threaded Compositor] Apply scroll-offset and scale in Widget window coordinate.
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-05 00:55 PDT by Gwang Yoon Hwang
Modified: 2016-09-15 00:49 PDT (History)
5 users (show)

See Also:


Attachments
Patch (4.14 KB, patch)
2013-07-04 05:07 PDT, Gwang Yoon Hwang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gwang Yoon Hwang 2013-06-05 00:55:32 PDT
We need to apply scrolling and scaling to mouse event when we are in
    delegatedScrolling. To do that, scroll-offset should be cached in
    WebPageProxy, because mouse event should be transformed at its creation
    time.
    
    No new tests, covered by existing tests.
Comment 1 Gwang Yoon Hwang 2013-07-04 05:07:02 PDT
Created attachment 206080 [details]
Patch
Comment 2 Michael Catanzaro 2016-01-02 08:46:53 PST
Comment on attachment 206080 [details]
Patch

Is this patch still needed? I'm going to remove the r? since I presume it's obsolete; please reset it if it's still needed.
Comment 3 Michael Catanzaro 2016-01-02 08:56:02 PST
Comment on attachment 206080 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=206080&action=review

Nevermind, you can just close the bug if it's obsolete.

> Source/WebCore/platform/Widget.cpp:145
> +IntRect Widget::convertFromRootToContainingWindow(const Widget* widget, const IntRect& rect)

These functions ought to take a const Widget& rather than a const Widget*, since it will crash if widget is ever null. (That should be changed in a follow-up patch.)

> Source/WebCore/platform/Widget.cpp:148
> +    const ScrollView* scrollView = widget->root();

scrollView can never be null here?
Comment 4 Carlos Garcia Campos 2016-06-14 04:01:12 PDT
Comment on attachment 206080 [details]
Patch

Clearing flags, we need an explanation of what is broken and what this fixes. Widget doesn't looke like the right place for this to me, but I don't really understand the change.