Bug 117221 - Modify scripts to support VS2010 build environment
Summary: Modify scripts to support VS2010 build environment
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-04 21:04 PDT by Roger Fong
Modified: 2013-06-04 21:21 PDT (History)
2 users (show)

See Also:

Attachments
patch (11.69 KB, patch)
2013-06-04 21:06 PDT, Roger Fong 		bfulgham: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-06-04 21:04:55 PDT 
Change scripts to use VS2010 and set appropriate build environment variables.
Comment 1 Roger Fong 2013-06-04 21:06:30 PDT 
Created attachment 203750 [details]
patch
Comment 2 Brent Fulgham 2013-06-04 21:13:03 PDT 
Comment on attachment 203750 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203750&action=review

Looks good, but I think we want to keep the WEBKIT_SOURCE environment setup.

> Scripts/webkitdirs.pm:-1583
> -        $variablesToSet{WEBKIT_SOURCE} = windowsSourceSourceDir() unless $ENV{WEBKIT_SOURCE};

I don't think you want to get rid of this one!

> Scripts/webkitdirs.pm:-1624
> -        }

Ditto -- don't we need this?

> Scripts/webkitdirs.pm:-1669
> -    }

Getting rid of this stanza is good ....

> Scripts/webkitdirs.pm:-1673
> -    }

... but getting rid of this stanza is not.
Comment 3 Brent Fulgham 2013-06-04 21:14:49 PDT 
Comment on attachment 203750 [details]
patch

Whoops! Roger just explained that he did indeed get rid of the need for WEBKIT_SOURCE.  So full speed ahead!
Comment 4 Roger Fong 2013-06-04 21:21:19 PDT 
http://trac.webkit.org/changeset/151196