RESOLVED FIXED 117221
Modify scripts to support VS2010 build environment 
https://bugs.webkit.org/show_bug.cgi?id=117221
Summary Modify scripts to support VS2010 build environment
Roger Fong
Reported 2013-06-04 21:04:55 PDT
Change scripts to use VS2010 and set appropriate build environment variables.
Attachments
patch (11.69 KB, patch)
2013-06-04 21:06 PDT, Roger Fong 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Roger Fong
Comment 1 2013-06-04 21:06:30 PDT
Created attachment 203750 [details] patch
Brent Fulgham
Comment 2 2013-06-04 21:13:03 PDT
Comment on attachment 203750 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203750&action=review Looks good, but I think we want to keep the WEBKIT_SOURCE environment setup. > Scripts/webkitdirs.pm:-1583 > - $variablesToSet{WEBKIT_SOURCE} = windowsSourceSourceDir() unless $ENV{WEBKIT_SOURCE}; I don't think you want to get rid of this one! > Scripts/webkitdirs.pm:-1624 > - } Ditto -- don't we need this? > Scripts/webkitdirs.pm:-1669 > - } Getting rid of this stanza is good .... > Scripts/webkitdirs.pm:-1673 > - } ... but getting rid of this stanza is not.
Brent Fulgham
Comment 3 2013-06-04 21:14:49 PDT
Comment on attachment 203750 [details] patch Whoops! Roger just explained that he did indeed get rid of the need for WEBKIT_SOURCE. So full speed ahead!
Roger Fong
Comment 4 2013-06-04 21:21:19 PDT
http://trac.webkit.org/changeset/151196
Note You need to log in before you can comment on or make changes to this bug.