Dirk Pranke pointed out that changes I made under Bug 117098 improperly treated the "win32" and "cygwin" variants of Windows builds as the same thing. Unfortunately, Windows does not provide a 'ps' tool, and so cannot be handled the same way as our Cygwin infrastructure. This patch makes the following corrections: 1. It returns to the original "win32" behavior of returning an empty list when attempting to find running PIDs. 2. Revise crashlog object to accept a "results directory" argument, rather than requiring the user to pass a port object when attempting to retrieve crash logs.
Created attachment 203730 [details] Patch
Comment on attachment 203730 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203730&action=review > Tools/Scripts/webkitpy/common/system/crashlogs.py:39 > + self._results_directory = results_directory I was suggesting you make one change or the other, and you came up with a weird hybrid :). I would just pass results_directory into find_newest_log(), but this is okay, too.
Committed r151191: <http://trac.webkit.org/changeset/151191>