WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
117206
[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
https://bugs.webkit.org/show_bug.cgi?id=117206
Summary
[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in th...
Brendan Long
Reported
2013-06-04 10:16:33 PDT
[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
Attachments
Patch
(4.26 KB, patch)
2013-06-04 10:19 PDT
,
Brendan Long
no flags
Details
Formatted Diff
Diff
Rebased
(4.46 KB, patch)
2013-09-05 13:17 PDT
,
Brendan Long
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Brendan Long
Comment 1
2013-06-04 10:19:32 PDT
Created
attachment 203710
[details]
Patch
Brendan Long
Comment 2
2013-07-11 15:53:44 PDT
This causes annoying warning messages during builds.
WebKit Commit Bot
Comment 3
2013-09-05 06:11:51 PDT
Comment on
attachment 203710
[details]
Patch Rejecting
attachment 203710
[details]
from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 203710, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/Target.pri Hunk #1 succeeded at 3326 (offset -37 lines). Hunk #2 FAILED at 3333. 1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Target.pri.rej patching file Source/widgetsapi.pri patching file ChangeLog Hunk #1 succeeded at 1 with fuzz 3. Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output:
http://webkit-queues.appspot.com/results/1690882
Brendan Long
Comment 4
2013-09-05 13:17:20 PDT
Created
attachment 210652
[details]
Rebased
Brendan Long
Comment 5
2013-09-05 15:05:34 PDT
I rebased the patch so it will apply cleanly again.
WebKit Commit Bot
Comment 6
2013-09-05 22:46:21 PDT
Comment on
attachment 210652
[details]
Rebased Clearing flags on attachment: 210652 Committed
r155175
: <
http://trac.webkit.org/changeset/155175
>
WebKit Commit Bot
Comment 7
2013-09-05 22:46:23 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug