Bug 117206 - [Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
Summary: [Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-04 10:16 PDT by Brendan Long
Modified: 2013-09-05 22:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.26 KB, patch)
2013-06-04 10:19 PDT, Brendan Long 		no flags Details | Formatted Diff | Diff
Rebased (4.46 KB, patch)
2013-09-05 13:17 PDT, Brendan Long 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Long 2013-06-04 10:16:33 PDT 
[Qt] DefaultFullScreenVideoHandler and PlatformVideoWindow are included in the build when they are disabled
Comment 1 Brendan Long 2013-06-04 10:19:32 PDT 
Created attachment 203710 [details]
Patch
Comment 2 Brendan Long 2013-07-11 15:53:44 PDT 
This causes annoying warning messages during builds.
Comment 3 WebKit Commit Bot 2013-09-05 06:11:51 PDT 
Comment on attachment 203710 [details]
Patch

Rejecting attachment 203710 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 203710, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/Target.pri
Hunk #1 succeeded at 3326 (offset -37 lines).
Hunk #2 FAILED at 3333.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Target.pri.rej
patching file Source/widgetsapi.pri
patching file ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Philippe Normand']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/1690882
Comment 4 Brendan Long 2013-09-05 13:17:20 PDT 
Created attachment 210652 [details]
Rebased
Comment 5 Brendan Long 2013-09-05 15:05:34 PDT 
I rebased the patch so it will apply cleanly again.
Comment 6 WebKit Commit Bot 2013-09-05 22:46:21 PDT 
Comment on attachment 210652 [details]
Rebased

Clearing flags on attachment: 210652

Committed r155175: <http://trac.webkit.org/changeset/155175>
Comment 7 WebKit Commit Bot 2013-09-05 22:46:23 PDT 
All reviewed patches have been landed.  Closing bug.