Bug 117204 - Remove [NoInterfaceObject] from XPathExpression and NodeIterator
Summary: Remove [NoInterfaceObject] from XPathExpression and NodeIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks: 115853
  Show dependency tree / graph
 
Reported: 2013-06-04 10:12 PDT by Chris Dumez
Modified: 2013-06-04 13:27 PDT (History)
9 users (show)

See Also:

Attachments
Patch (14.92 KB, patch)
2013-06-04 10:30 PDT, Chris Dumez 		ap: review+
Details | Formatted Diff | Diff
Patch for landing (16.06 KB, patch)
2013-06-04 11:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2013-06-04 10:12:37 PDT 
XPathExpression and NodeIterator interfaces should not have [NoInterfaceObject] extended attribute according to their respective specifications:
http://www.w3.org/TR/DOM-Level-3-XPath/xpath.html#XPathExpression
http://www.w3.org/TR/DOM-Level-2-Traversal-Range/traversal.html#Traversal-NodeIterator
Comment 1 Chris Dumez 2013-06-04 10:30:55 PDT 
Created attachment 203711 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-06-04 10:38:57 PDT 
Comment on attachment 203711 [details]
Patch

Looks like this matches Firefox at least...
Comment 3 Chris Dumez 2013-06-04 10:57:40 PDT 
(In reply to comment #2)
> (From update of attachment 203711 [details])
> Looks like this matches Firefox at least...

Right. Sorry, I should have mentioned that.
I'm going to submit the same patch to Blink as well.
Comment 4 Chris Dumez 2013-06-04 11:55:59 PDT 
Created attachment 203716 [details]
Patch for landing

Rebaseline fast/dom/dom-constructors.html as well.
Comment 5 WebKit Commit Bot 2013-06-04 13:27:29 PDT 
Comment on attachment 203716 [details]
Patch for landing

Clearing flags on attachment: 203716

Committed r151182: <http://trac.webkit.org/changeset/151182>
Comment 6 WebKit Commit Bot 2013-06-04 13:27:33 PDT 
All reviewed patches have been landed.  Closing bug.