Bug 117202 - Avoid multiple copies of inline script & style strings
Summary: Avoid multiple copies of inline script & style strings
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Keywords: BlinkMergeCandidate
Depends on:
Reported: 2013-06-04 08:56 PDT by Arunprasad Rajkumar
Modified: 2013-06-05 14:20 PDT (History)
8 users (show)

See Also:

Patch (4.94 KB, patch)
2013-06-05 12:40 PDT, Arunprasad Rajkumar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arunprasad Rajkumar 2013-06-04 08:56:52 PDT

Above fix avoids the multiple copies of contents inside inline <script> & <style>
Comment 1 Alexey Proskuryakov 2013-06-05 10:58:24 PDT
Sounds like a really valuable optimization.
Comment 2 Arunprasad Rajkumar 2013-06-05 12:40:13 PDT
Created attachment 203874 [details]
Comment 3 Brent Fulgham 2013-06-05 13:59:11 PDT
Seems like a good change.  ap, any reason you did not r+ this?
Comment 4 Darin Adler 2013-06-05 13:59:43 PDT
Comment on attachment 203874 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=203874&action=review

> Source/WebCore/html/parser/HTMLConstructionSite.cpp:500
> +    unsigned lengthLimit = shouldUseLengthLimit(task.parent.get()) ? Text::defaultLengthLimit : std::numeric_limits<unsigned>::max();

Too bad we need to compute this limit ahead of time. Sure would be nice to only do the work when we actually get close enough to hitting a limit.
Comment 5 WebKit Commit Bot 2013-06-05 14:20:38 PDT
Comment on attachment 203874 [details]

Clearing flags on attachment: 203874

Committed r151236: <http://trac.webkit.org/changeset/151236>
Comment 6 WebKit Commit Bot 2013-06-05 14:20:41 PDT
All reviewed patches have been landed.  Closing bug.