Bug 117201 – AX: WK2: accessibility position is calculated every time window frame is updated

• Status: RESOLVED
• Resolution: FIXED
• Component: Accessibility

[chris fleizach]

Evertyime WKView:_updateWIndowAndFrames is called, the AX position is also calculated. 

This impacts performance for all users.

[chris fleizach]

Created attachment 203703 [details]
patch

[Tim Horton]

Comment on attachment 203703 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review

> Source/WebKit2/UIProcess/API/mac/WKView.mm:460
> +    if (WebCore::AXObjectCache::accessibilityEnabled())

does this really work in the UIProcess? how?

[chris fleizach]

(In reply to comment #2)
> (From update of attachment 203703 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review
> 
> > Source/WebKit2/UIProcess/API/mac/WKView.mm:460
> > +    if (WebCore::AXObjectCache::accessibilityEnabled())
> 
> does this really work in the UIProcess? how?

it just a static boolean, so we can use it to store whether we're enabled or not and it's valid for the lifetime of the process using it

[Tim Horton]

Comment on attachment 203703 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review

>>> Source/WebKit2/UIProcess/API/mac/WKView.mm:460
>>> +    if (WebCore::AXObjectCache::accessibilityEnabled())
>> 
>> does this really work in the UIProcess? how?
> 
> it just a static boolean, so we can use it to store whether we're enabled or not and it's valid for the lifetime of the process using it

OK, separate values tracking the same thing in the same place, but not needing to be kept in sync explicitly.

[chris fleizach]

(In reply to comment #4)
> (From update of attachment 203703 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203703&action=review
> 
> >>> Source/WebKit2/UIProcess/API/mac/WKView.mm:460
> >>> +    if (WebCore::AXObjectCache::accessibilityEnabled())
> >> 
> >> does this really work in the UIProcess? how?
> > 
> > it just a static boolean, so we can use it to store whether we're enabled or not and it's valid for the lifetime of the process using it
> 
> OK, separate values tracking the same thing in the same place, but not needing to be kept in sync explicitly.

correct

[WebKit Commit Bot]

Comment on attachment 203703 [details]
patch

Clearing flags on attachment: 203703

Committed r151181: <http://trac.webkit.org/changeset/151181>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.