RESOLVED FIXED Bug 117198
[GTK] Forwarding headers not generated for incremental build 
https://bugs.webkit.org/show_bug.cgi?id=117198
Summary [GTK] Forwarding headers not generated for incremental build
Wojciech Bielawski
Reported 2013-06-04 07:43:42 PDT
When adding some includes in source files in Tools/ (like WebKitTestRunner/EventSendingController.cpp) a forwarding headers will not be generated for incremental build.
Attachments
Generate forwarding headers if needed even for incremental build (663 bytes, patch)
2013-06-04 07:52 PDT, Wojciech Bielawski 		no flags
DetailsFormatted DiffDiff
Now with changelog (1.28 KB, patch)
2013-06-04 08:08 PDT, Wojciech Bielawski 		cgarcia: review-
DetailsFormatted DiffDiff
changelog generated with script (and --bug argument) (1.22 KB, patch)
2013-06-05 03:29 PDT, Wojciech Bielawski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Wojciech Bielawski
Comment 1 2013-06-04 07:52:16 PDT
Created attachment 203696 [details] Generate forwarding headers if needed even for incremental build
Wojciech Bielawski
Comment 2 2013-06-04 07:53:12 PDT
Thanks for Zan Dobersek.
Wojciech Bielawski
Comment 3 2013-06-04 08:08:29 PDT
Created attachment 203699 [details] Now with changelog
Carlos Garcia Campos
Comment 4 2013-06-05 02:17:41 PDT
Comment on attachment 203699 [details] Now with changelog View in context: https://bugs.webkit.org/attachment.cgi?id=203699&action=review Patch looks good to me, could you please update the changelog entry to match the bug? We have scripts that parse the changelog entries, so it's important to make sure they are generated correctly. Use the prepare-ChangeLog script to make sure. > Tools/ChangeLog:3 > + [GTK] Generate forwarding headers if needed even for incremental build. This doesn't match the bug title, you should use the Tools/Scripts/prepare-ChangeLog to generate the changelog entry. > Tools/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=117198. And this doesn't finish with a period
Wojciech Bielawski
Comment 5 2013-06-05 03:29:21 PDT
Created attachment 203786 [details] changelog generated with script (and --bug argument) Now prepare-ChangeLog had generated Title without period on the end. Is it correct?
WebKit Commit Bot
Comment 6 2013-06-05 05:26:57 PDT
Comment on attachment 203786 [details] changelog generated with script (and --bug argument) Clearing flags on attachment: 203786 Committed r151215: <http://trac.webkit.org/changeset/151215>
WebKit Commit Bot
Comment 7 2013-06-05 05:26:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.