Bug 117198 - [GTK] Forwarding headers not generated for incremental build
Summary: [GTK] Forwarding headers not generated for incremental build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wojciech Bielawski
URL:
Keywords:
Depends on:
Blocks: contextClick().click
  Show dependency tree / graph
 
Reported: 2013-06-04 07:43 PDT by Wojciech Bielawski
Modified: 2013-06-05 05:26 PDT (History)
4 users (show)

See Also:

Attachments
Generate forwarding headers if needed even for incremental build (663 bytes, patch)
2013-06-04 07:52 PDT, Wojciech Bielawski 		no flags Details | Formatted Diff | Diff
Now with changelog (1.28 KB, patch)
2013-06-04 08:08 PDT, Wojciech Bielawski 		cgarcia: review-
Details | Formatted Diff | Diff
changelog generated with script (and --bug argument) (1.22 KB, patch)
2013-06-05 03:29 PDT, Wojciech Bielawski 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wojciech Bielawski 2013-06-04 07:43:42 PDT 
When adding some includes in source files in Tools/ (like WebKitTestRunner/EventSendingController.cpp) a forwarding headers will not be generated for incremental build.
Comment 1 Wojciech Bielawski 2013-06-04 07:52:16 PDT 
Created attachment 203696 [details]
Generate forwarding headers if needed even for incremental build
Comment 2 Wojciech Bielawski 2013-06-04 07:53:12 PDT 
Thanks for Zan Dobersek.
Comment 3 Wojciech Bielawski 2013-06-04 08:08:29 PDT 
Created attachment 203699 [details]
Now with changelog
Comment 4 Carlos Garcia Campos 2013-06-05 02:17:41 PDT 
Comment on attachment 203699 [details]
Now with changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=203699&action=review

Patch looks good to me, could you please update the changelog entry to match the bug? We have scripts that parse the changelog entries, so it's important to make sure they are generated correctly. Use the prepare-ChangeLog script to make sure.

> Tools/ChangeLog:3
> +        [GTK] Generate forwarding headers if needed even for incremental build.

This doesn't match the bug title, you should use the Tools/Scripts/prepare-ChangeLog to generate the changelog entry.

> Tools/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=117198.

And this doesn't finish with a period
Comment 5 Wojciech Bielawski 2013-06-05 03:29:21 PDT 
Created attachment 203786 [details]
changelog generated with script (and --bug argument)

Now prepare-ChangeLog had generated Title without period on the end. Is it correct?
Comment 6 WebKit Commit Bot 2013-06-05 05:26:57 PDT 
Comment on attachment 203786 [details]
changelog generated with script (and --bug argument)

Clearing flags on attachment: 203786

Committed r151215: <http://trac.webkit.org/changeset/151215>
Comment 7 WebKit Commit Bot 2013-06-05 05:26:59 PDT 
All reviewed patches have been landed.  Closing bug.