Bug 117196 - [curl] Headers should be parsed as utf8 if possible
Summary: [curl] Headers should be parsed as utf8 if possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 117300
  Show dependency tree / graph
 
Reported: 2013-06-04 07:31 PDT by Peter Gal
Modified: 2013-06-13 06:59 PDT (History)
2 users (show)

See Also:

Attachments
proposed patch (1.42 KB, patch)
2013-06-04 07:33 PDT, Peter Gal 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Gal 2013-06-04 07:31:37 PDT 
When the server returns the header data for the curl backend it is passed to be converted as a latin1 string. This is not always good.
For example there is a testcase which fails currently: http/tests/download/literal-utf-8.html.

The solution would be to process the input headers as utf8 strings. This solution in the libsoup backend.
Comment 1 Peter Gal 2013-06-04 07:32:07 PDT 
I mean:
"This solution in the libsoup backend." -> This solution is also used in the libsoup backend.
Comment 2 Peter Gal 2013-06-04 07:33:11 PDT 
Created attachment 203694 [details]
proposed patch
Comment 3 Brent Fulgham 2013-06-04 20:36:58 PDT 
Comment on attachment 203694 [details]
proposed patch

r=me
Comment 4 WebKit Commit Bot 2013-06-04 20:58:36 PDT 
Comment on attachment 203694 [details]
proposed patch

Clearing flags on attachment: 203694

Committed r151195: <http://trac.webkit.org/changeset/151195>
Comment 5 WebKit Commit Bot 2013-06-04 20:58:38 PDT 
All reviewed patches have been landed.  Closing bug.