Bug 117195 - [Qt] Font::shouldUseSmoothing() has fake dependency on Qt 5.1
Summary: [Qt] Font::shouldUseSmoothing() has fake dependency on Qt 5.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on: 117699 117702
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-04 06:46 PDT by Allan Sandfeld Jensen
Modified: 2013-06-17 09:04 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.98 KB, patch)
2013-06-04 07:05 PDT, Allan Sandfeld Jensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-06-04 06:46:02 PDT
We should get rid of this fake dependency as the changes it causes could mask real regressions in Qt 5.1.
Comment 1 Allan Sandfeld Jensen 2013-06-04 07:05:16 PDT
Created attachment 203693 [details]
Patch
Comment 2 Zoltan Arvai 2013-06-04 15:28:45 PDT
It seems about 5400 png result are affected. Landing rebaselines will take a while. Is there a size limit for a commit? :)
Comment 3 Csaba Osztrogonác 2013-06-05 00:09:00 PDT
(In reply to comment #2)
> It seems about 5400 png result are affected. Landing rebaselines will take a while. Is there a size limit for a commit? :)

There isn't size limit. But I suggest rebasing in ~500 sized batches
to avoid LayoutTests/ChangeLog conflict during half an hour long commit.
And commit in an IDLE time.
Comment 4 WebKit Commit Bot 2013-06-05 02:29:01 PDT
Comment on attachment 203693 [details]
Patch

Clearing flags on attachment: 203693

Committed r151205: <http://trac.webkit.org/changeset/151205>
Comment 5 WebKit Commit Bot 2013-06-05 02:29:04 PDT
All reviewed patches have been landed.  Closing bug.