Bug 117188 - [BLACKBERRY]RSS not working with browser
Summary: [BLACKBERRY]RSS not working with browser
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit BlackBerry (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-06-04 03:43 PDT by minggang wang
Modified: 2013-09-17 19:40 PDT (History)
2 users (show)

See Also:

path (8.58 KB, patch)
2013-06-04 03:56 PDT, minggang wang
mingwang: commit-queue-
Details | Formatted Diff | Diff
new patch (14.35 KB, patch)
2013-06-04 04:09 PDT, minggang wang
mingwang: review-
Details | Formatted Diff | Diff
correct patch (8.90 KB, patch)
2013-06-04 04:17 PDT, minggang wang
rwlbuis: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description minggang wang 2013-06-04 03:43:02 PDT
Internal PR 341330 
Internal reviewed by Joe Mason
Browser won't recognize the RSS content, when the "Content-Type" in http header is wrong (not "text/xml").
Comment 1 minggang wang 2013-06-04 03:56:21 PDT
Created attachment 203675 [details]
Comment 2 minggang wang 2013-06-04 04:09:52 PDT
Created attachment 203678 [details]
new patch
Comment 3 minggang wang 2013-06-04 04:17:58 PDT
Created attachment 203679 [details]
correct patch
Comment 4 minggang wang 2013-06-05 01:22:12 PDT
Comment on attachment 203678 [details]
new patch

wrong patch
Comment 5 minggang wang 2013-06-05 01:35:28 PDT
Comment on attachment 203675 [details]

wrong patch
Comment 6 minggang wang 2013-06-05 01:36:35 PDT
Comment on attachment 203679 [details]
correct patch

pls review this patch
Comment 7 Rob Buis 2013-06-13 10:11:39 PDT
Comment on attachment 203679 [details]
correct patch

Looks good.
Comment 8 WebKit Commit Bot 2013-06-13 10:12:49 PDT
Comment on attachment 203679 [details]
correct patch

Rejecting attachment 203679 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 203679, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.appspot.com/results/896009
Comment 9 Rob Buis 2013-07-30 07:40:23 PDT
(In reply to comment #6)
> (From update of attachment 203679 [details])
> pls review this patch

Sorry for forgetting about this one. Mingwang if you still want this in you have to fix the Changelog. If it is not needed you can close the bug.