Bug 117179 - Use the PlatformEvent timestamp when creating a DOM Event
Summary: Use the PlatformEvent timestamp when creating a DOM Event
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-03 21:57 PDT by Benjamin Poulain
Modified: 2013-06-19 15:41 PDT (History)
12 users (show)

See Also:


Attachments
Patch (43.60 KB, patch)
2013-06-03 22:01 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (577.57 KB, application/zip)
2013-06-03 23:04 PDT, Build Bot
no flags Details
Patch (43.62 KB, patch)
2013-06-04 12:47 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (533.83 KB, application/zip)
2013-06-04 14:25 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (436.92 KB, application/zip)
2013-06-05 08:31 PDT, Build Bot
no flags Details
Patch (51.97 KB, patch)
2013-06-06 14:57 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (52.12 KB, patch)
2013-06-06 15:10 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Patch (52.37 KB, patch)
2013-06-17 19:52 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-3 for win-future (794.66 KB, application/zip)
2013-06-18 06:01 PDT, Build Bot
no flags Details
Archive of layout-test-results from APPLE-EWS-2 for win-future (793.59 KB, application/zip)
2013-06-18 07:02 PDT, Build Bot
no flags Details
Patch (53.57 KB, patch)
2013-06-18 14:20 PDT, Benjamin Poulain
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from APPLE-EWS-2 for win-future (793.73 KB, application/zip)
2013-06-18 22:03 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-06-03 21:57:02 PDT
Use the PlatformEvent timestamp when creating a DOM Event
Comment 1 Benjamin Poulain 2013-06-03 22:01:53 PDT
Created attachment 203651 [details]
Patch
Comment 2 WebKit Commit Bot 2013-06-03 22:03:31 PDT
Attachment 203651 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/MouseRelatedEvent.h', u'Source/WebCore/dom/TouchEvent.cpp', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/UIEventWithKeyState.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPDFView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/WebEventFactory.mm']" exit_code: 1
Source/WebCore/dom/WheelEvent.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/KeyboardEvent.cpp:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2013-06-03 23:04:10 PDT
Comment on attachment 203651 [details]
Patch

Attachment 203651 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/672994

New failing tests:
editing/pasteboard/smart-drag-drop.html
editing/pasteboard/drag-drop-input-textarea.html
fast/dom/capturing-event-listeners.html
editing/pasteboard/drop-text-events.html
editing/pasteboard/drag-drop-list.html
editing/selection/4895428-1.html
http/tests/inspector/inspect-element.html
accessibility/file-upload-button-with-axpress.html
editing/pasteboard/dataTransfer-setData-getData.html
editing/pasteboard/drag-drop-dead-frame.html
accessibility/label-element-press.html
accessibility/aria-activedescendant-crash.html
editing/pasteboard/drag-drop-url-text.html
editing/pasteboard/subframe-dragndrop-1.html
http/tests/cache/willsendrequest-returns-null-for-memory-cache-load.html
editing/pasteboard/drag-list-item.html
editing/pasteboard/get-data-text-plain-drop.html
editing/pasteboard/drag-drop-to-data-url.html
editing/selection/contains-boundaries.html
editing/pasteboard/drop-inputtext-acquires-style.html
http/tests/cache/post-with-cached-subresources.php
editing/pasteboard/drag-drop-modifies-page.html
editing/selection/4895428-4.html
editing/pasteboard/cleanup-on-move.html
dom/xhtml/level2/html/HTMLInputElement21.xhtml
http/tests/cache/post-redirect-get.php
fast/dom/HTMLButtonElement/change-type.html
editing/pasteboard/drag-drop-url-with-style.html
http/tests/inspector/resource-parameters.html
dom/html/level2/html/HTMLInputElement21.html
Comment 4 Build Bot 2013-06-03 23:04:13 PDT
Created attachment 203653 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 5 Benjamin Poulain 2013-06-04 12:47:04 PDT
Created attachment 203718 [details]
Patch
Comment 6 WebKit Commit Bot 2013-06-04 12:49:45 PDT
Attachment 203718 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/MouseRelatedEvent.h', u'Source/WebCore/dom/TouchEvent.cpp', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/UIEventWithKeyState.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPDFView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/WebEventFactory.mm']" exit_code: 1
Source/WebCore/dom/WheelEvent.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/KeyboardEvent.cpp:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 24 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Darin Adler 2013-06-04 12:57:17 PDT
Comment on attachment 203718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203718&action=review

> Source/WebCore/dom/Event.cpp:82
> +    , m_createTime(convertSecondsToDOMTimeStamp(timestamp ? timestamp : currentTime()))

It’s a little ugly to use 0.0 as the magic number that means “use current time” given that this is a double. We could also use NAN or some other value. I think a named constant is needed because I keep getting confused at every single call site by these 0. that mean “use the current time”.

> Source/WebCore/dom/KeyboardEvent.cpp:121
> +    : UIEventWithKeyState(eventType, initializer.bubbles, initializer.cancelable, 0., initializer.view, initializer.detail, initializer.ctrlKey, initializer.altKey, initializer.shiftKey, initializer.metaKey)

This 0. in the middle of the line is really mysterious. A named constant would be easier to understand, unless there is a major obstacle to this. I found these confusing at almost every call site, but I only commented here at the first one I saw.

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:404
> -        m_timestamp                         = [event timestamp];
> +        m_timestamp                         = currentTime();

I don’t understand this change at all! I read the change log over and over again and can’t figure out why you are doing this. It seems the opposite of the goal of this patch. Maybe it’s a first step and you wanted to avoid changing behavior, and then you are coming back here to change this back?

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:431
> -        m_timestamp                         = [event timestamp];
> +        m_timestamp                         = currentTime();

Same.

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:475
> -        m_timestamp                         = [event timestamp];
> +        m_timestamp                         = currentTime();

Same.

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:524
> -        m_timestamp                         = [event timestamp];
> +        m_timestamp                         = currentTime();

Same.

> Source/WebKit2/Shared/mac/WebEventFactory.mm:366
> -    double timestamp                        = [event timestamp];
> +    double timestamp                        = currentTime();

Same.

> Source/WebKit2/Shared/mac/WebEventFactory.mm:421
> -    double timestamp                        = [event timestamp];
> +    double timestamp                        = currentTime();

Same.

> Source/WebKit2/Shared/mac/WebEventFactory.mm:439
> -    double timestamp                = [event timestamp];
> +    double timestamp                = currentTime();

Same.

> Source/WebKit2/Shared/mac/WebEventFactory.mm:469
> -    double timestamp                = [event timestamp];
> +    double timestamp                = currentTime();

Same.
Comment 8 Benjamin Poulain 2013-06-04 13:10:34 PDT
(In reply to comment #7)
> (From update of attachment 203718 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203718&action=review
> 
> > Source/WebCore/dom/Event.cpp:82
> > +    , m_createTime(convertSecondsToDOMTimeStamp(timestamp ? timestamp : currentTime()))
> 
> It’s a little ugly to use 0.0 as the magic number that means “use current time” given that this is a double. We could also use NAN or some other value. I think a named constant is needed because I keep getting confused at every single call site by these 0. that mean “use the current time”.

I used 0 for consistency.
In the WebKit/WebKit2 layers, ports are using 0. when not providing a timestamp.

What I could do is double all the constructor to have one taking a timestamp and one not. This would avoid the magic 0 in our layers.
Ports would have to update their WebKit layers to keep working.

> > Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:404
> > -        m_timestamp                         = [event timestamp];
> > +        m_timestamp                         = currentTime();
> 
> I don’t understand this change at all! I read the change log over and over again and can’t figure out why you are doing this. It seems the opposite of the goal of this patch. Maybe it’s a first step and you wanted to avoid changing behavior, and then you are coming back here to change this back?

OS X does not provide an event timestamp relative to epoch, it gives a relative running time since system startup.

I had filed <rdar://problem/14055576>, maybe you know a solution?
Comment 9 Build Bot 2013-06-04 14:25:12 PDT
Comment on attachment 203718 [details]
Patch

Attachment 203718 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/700819

New failing tests:
editing/pasteboard/drag-drop-to-data-url.html
Comment 10 Build Bot 2013-06-04 14:25:14 PDT
Created attachment 203726 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 11 Darin Adler 2013-06-04 14:53:46 PDT
Comment on attachment 203718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203718&action=review

>>> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:404
>>> +        m_timestamp                         = currentTime();
>> 
>> I don’t understand this change at all! I read the change log over and over again and can’t figure out why you are doing this. It seems the opposite of the goal of this patch. Maybe it’s a first step and you wanted to avoid changing behavior, and then you are coming back here to change this back?
> 
> OS X does not provide an event timestamp relative to epoch, it gives a relative running time since system startup.
> 
> I had filed <rdar://problem/14055576>, maybe you know a solution?

You’ll have to test it, but I think this might work:

    mach_timebase_info_data_t timebase_info;
    mach_timebase_info(&timebase_info);
    double startupTime = CFAbsoluteTimeGetCurrent() - (double)mach_absolute_time() * timebase_info.numer / timebase_info.denom * 1e9;

    m_timestamp = startupTime + [event timestamp];

Need to include the appropriate headers, of course.
Comment 12 Darin Adler 2013-06-04 14:54:35 PDT
Comment on attachment 203718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203718&action=review

>>>> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:404
>>>> +        m_timestamp                         = currentTime();
>>> 
>>> I don’t understand this change at all! I read the change log over and over again and can’t figure out why you are doing this. It seems the opposite of the goal of this patch. Maybe it’s a first step and you wanted to avoid changing behavior, and then you are coming back here to change this back?
>> 
>> OS X does not provide an event timestamp relative to epoch, it gives a relative running time since system startup.
>> 
>> I had filed <rdar://problem/14055576>, maybe you know a solution?
> 
> You’ll have to test it, but I think this might work:
> 
>     mach_timebase_info_data_t timebase_info;
>     mach_timebase_info(&timebase_info);
>     double startupTime = CFAbsoluteTimeGetCurrent() - (double)mach_absolute_time() * timebase_info.numer / timebase_info.denom * 1e9;
> 
>     m_timestamp = startupTime + [event timestamp];
> 
> Need to include the appropriate headers, of course.

And you’d want to compute that startupTime value only once.
Comment 13 Build Bot 2013-06-05 08:31:17 PDT
Comment on attachment 203718 [details]
Patch

Attachment 203718 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/709851

New failing tests:
editing/pasteboard/smart-drag-drop.html
editing/pasteboard/drag-drop-input-textarea.html
fast/events/ondragenter.html
editing/pasteboard/drop-text-events.html
editing/pasteboard/drag-drop-list.html
fast/events/crash-on-mutate-during-drop.html
http/tests/inspector/appcache/appcache-manifest-with-non-existing-file.html
editing/selection/4895428-1.html
http/tests/inspector/inspect-element.html
editing/pasteboard/dataTransfer-setData-getData.html
fast/events/moving-text-should-fire-drop-and-dragend-events-2.html
editing/pasteboard/drag-drop-dead-frame.html
fast/lists/drag-into-marker.html
editing/pasteboard/drag-drop-url-with-style.html
editing/pasteboard/drag-drop-url-text.html
editing/pasteboard/subframe-dragndrop-1.html
fast/forms/drag-out-of-textarea.html
editing/pasteboard/drag-list-item.html
editing/pasteboard/get-data-text-plain-drop.html
editing/pasteboard/drag-drop-to-data-url.html
editing/selection/contains-boundaries.html
fast/events/moving-text-should-fire-drop-and-dragend-events.html
editing/pasteboard/drop-inputtext-acquires-style.html
fast/forms/drag-into-textarea.html
editing/pasteboard/drag-drop-modifies-page.html
editing/selection/4895428-4.html
editing/pasteboard/cleanup-on-move.html
platform/mac/editing/deleting/deletionUI-single-instance.html
fast/loader/javascript-url-in-object.html
fast/events/5056619.html
Comment 14 Build Bot 2013-06-05 08:31:19 PDT
Created attachment 203854 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 15 Benjamin Poulain 2013-06-06 14:57:32 PDT
Created attachment 203970 [details]
Patch
Comment 16 WebKit Commit Bot 2013-06-06 14:59:43 PDT
Attachment 203970 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/MouseRelatedEvent.h', u'Source/WebCore/dom/TouchEvent.cpp', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/UIEventWithKeyState.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.h', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPDFView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/WebEventFactory.mm', u'Tools/ChangeLog', u'Tools/WebKitTestRunner/mac/EventSenderProxy.mm']" exit_code: 1
Source/WebCore/dom/WheelEvent.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/UIEventWithKeyState.h:58:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/KeyboardEvent.cpp:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 17 EFL EWS Bot 2013-06-06 15:02:50 PDT
Comment on attachment 203970 [details]
Patch

Attachment 203970 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/658749
Comment 18 EFL EWS Bot 2013-06-06 15:04:32 PDT
Comment on attachment 203970 [details]
Patch

Attachment 203970 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/715424
Comment 19 Early Warning System Bot 2013-06-06 15:05:56 PDT
Comment on attachment 203970 [details]
Patch

Attachment 203970 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/745558
Comment 20 Benjamin Poulain 2013-06-06 15:10:07 PDT
Created attachment 203971 [details]
Patch
Comment 21 WebKit Commit Bot 2013-06-06 15:12:29 PDT
Attachment 203971 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/MouseRelatedEvent.h', u'Source/WebCore/dom/TouchEvent.cpp', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/UIEventWithKeyState.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.h', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPDFView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/WebEventFactory.mm', u'Tools/ChangeLog', u'Tools/WebKitTestRunner/mac/EventSenderProxy.mm']" exit_code: 1
Source/WebCore/dom/WheelEvent.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/UIEventWithKeyState.h:58:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/KeyboardEvent.cpp:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Darin Adler 2013-06-06 15:50:22 PDT
Comment on attachment 203971 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203971&action=review

> Source/WebCore/platform/mac/PlatformEventFactoryMac.h:56
> +double getEventTimeStampSince1970(NSEvent*);

WebKit coding style says not to use the word “get” in a function name like this one.

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:350
> +static CFAbsoluteTime systemStartupTime;

Annoying to have this here since only two functions are allowed to use this. Using it instead of getCachedStartupTimeIntervalSince1970 would be a bug.

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:358
> +

Strange use of a blank line here. I say delete it or add more blank lines.

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:360
> +    systemStartupTime =  kCFAbsoluteTimeIntervalSince1970 + CFAbsoluteTimeGetCurrent() - elapsedTimeSinceStartup;

Extra space here.

> Source/WebCore/platform/mac/PlatformEventFactoryMac.mm:363
> +static CFTimeInterval getCachedStartupTimeIntervalSince1970()

WebKit coding style does not use the word “get” in the name of a function like this one.

> Tools/WebKitTestRunner/mac/EventSenderProxy.mm:148
> -                                       timestamp:currentEventTime()
> +                                       timestamp:GetCurrentEventTime() + currentEventTime()

I don’t understand the changes of this form; why would we add current event time to current event time? Seems like that would double it. If the code is this hard to read it needs a comment or named function or something.
Comment 23 Benjamin Poulain 2013-06-17 19:52:04 PDT
Created attachment 204878 [details]
Patch
Comment 24 WebKit Commit Bot 2013-06-17 19:58:52 PDT
Attachment 204878 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/MouseRelatedEvent.h', u'Source/WebCore/dom/TouchEvent.cpp', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/UIEventWithKeyState.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.h', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.mm', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPDFView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/WebEventFactory.mm', u'Tools/ChangeLog', u'Tools/WebKitTestRunner/mac/EventSenderProxy.mm']" exit_code: 1
Source/WebCore/dom/WheelEvent.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/UIEventWithKeyState.h:58:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/dom/KeyboardEvent.cpp:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 3 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 25 Build Bot 2013-06-18 06:01:16 PDT
Comment on attachment 204878 [details]
Patch

Attachment 204878 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/857568

New failing tests:
fast/forms/search-event-delay.html
Comment 26 Build Bot 2013-06-18 06:01:20 PDT
Created attachment 204906 [details]
Archive of layout-test-results from APPLE-EWS-3 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-3  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 27 Build Bot 2013-06-18 07:02:52 PDT
Comment on attachment 204878 [details]
Patch

Attachment 204878 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/898309

New failing tests:
fast/forms/search-event-delay.html
Comment 28 Build Bot 2013-06-18 07:02:56 PDT
Created attachment 204911 [details]
Archive of layout-test-results from APPLE-EWS-2 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-2  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 29 Benjamin Poulain 2013-06-18 14:20:33 PDT
Created attachment 204941 [details]
Patch
Comment 30 WebKit Commit Bot 2013-06-18 14:28:03 PDT
Attachment 204941 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/dom/Event.cpp', u'Source/WebCore/dom/Event.h', u'Source/WebCore/dom/GestureEvent.cpp', u'Source/WebCore/dom/GestureEvent.h', u'Source/WebCore/dom/KeyboardEvent.cpp', u'Source/WebCore/dom/KeyboardEvent.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseEvent.h', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/MouseRelatedEvent.h', u'Source/WebCore/dom/TouchEvent.cpp', u'Source/WebCore/dom/UIEvent.cpp', u'Source/WebCore/dom/UIEvent.h', u'Source/WebCore/dom/UIEventWithKeyState.h', u'Source/WebCore/dom/WheelEvent.cpp', u'Source/WebCore/dom/WheelEvent.h', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.h', u'Source/WebCore/platform/mac/PlatformEventFactoryMac.mm', u'Source/WebCore/platform/win/PlatformMouseEventWin.cpp', u'Source/WebKit/mac/ChangeLog', u'Source/WebKit/mac/WebView/WebPDFView.mm', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/Shared/mac/WebEventFactory.mm', u'Tools/ChangeLog', u'Tools/WebKitTestRunner/mac/EventSenderProxy.mm']" exit_code: 1
Source/WebCore/dom/WheelEvent.cpp:59:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/UIEventWithKeyState.h:58:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/platform/win/PlatformMouseEventWin.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/dom/KeyboardEvent.cpp:112:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 4 in 28 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 31 Build Bot 2013-06-18 22:02:55 PDT
Comment on attachment 204941 [details]
Patch

Attachment 204941 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/923429

New failing tests:
fast/media/mq-transform-03.html
fast/forms/search-event-delay.html
fast/media/mq-transform-02.html
platform/win/accessibility/multiple-select-element-role.html
Comment 32 Build Bot 2013-06-18 22:03:00 PDT
Created attachment 204970 [details]
Archive of layout-test-results from APPLE-EWS-2 for win-future

The attached test failures were seen while running run-webkit-tests on the win-ews.
Bot: APPLE-EWS-2  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit
Comment 33 Brent Fulgham 2013-06-19 11:31:06 PDT
(In reply to comment #32)
> Created an attachment (id=204970) [details]
> Archive of layout-test-results from APPLE-EWS-2 for win-future
> 
> The attached test failures were seen while running run-webkit-tests on the win-ews.
> Bot: APPLE-EWS-2  Port: win-future  Platform: CYGWIN_NT-6.1-WOW64-1.7.20-0.266-5-3-i686-32bit

I do not get these build errors when building locally against ToT.  It looks like the EWS system may not be configured properly, or is not accurately reflecting the current build environment.
Comment 34 Benjamin Poulain 2013-06-19 15:41:32 PDT
Comment on attachment 204941 [details]
Patch

Clearing flags on attachment: 204941

Committed r151757: <http://trac.webkit.org/changeset/151757>
Comment 35 Benjamin Poulain 2013-06-19 15:41:36 PDT
All reviewed patches have been landed.  Closing bug.