Bug 117178 – [regression] build failure WebKitFontFamilyNames.h missing

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[David Ronis]

I just tried buiding webkitgtk+ 2.1.1 on a slackware box.  The build dies with:

libtool: compile:  /usr/bin/g++ -DHAVE_CONFIG_H -I. -DBUILDING_WEBKIT -DPACKAGE_LOCALE_DIR=\"/opt/garnome-3.8/share/locale\" -DDATA_DIR=\"/opt/garnome-3.8/share\" -I./Source/WebCore/bindings -I./Source/WebCore/bindings/gobject -I./Source/WebKit/gtk -I./Source/WebKit/gtk/WebCoreSupport -I./Source/WebKit/gtk/webkit -I./DerivedSources/webkit -I./DerivedSources/webkitdom -ISource/WebKit/gtk/webkit -Wall -W -Wcast-align -Wchar-subscripts -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings -Wno-unused-parameter -Wno-parentheses -fno-exceptions -DBUILDING_CAIRO__ -DBUILDING_GTK__ -DBUILDING_WEBKIT2__ -I./Source/ThirdParty/ANGLE/src -I./Source/ThirdParty/ANGLE/include -I./Source/ThirdParty/ANGLE/include/GLSLANG -I./Source/ThirdParty/ANGLE/include/KHR -I./DerivedSources/Platform -DWEBKITGTK_API_VERSION_STRING=\"3.0\" -DDATA_DIR=\"/opt/garnome-3.8/share\" -I./Source/WebCore/platform -I./Source/WebCore/platform/animation -I./Source/WebCore/platform/audio -I./Source/WebCore/platform/cairo -I./Source/WebCore/platform/geoclue -I./Source/WebCore/platform/graphics -I./Source/WebCore/platform/graphics/cairo -I./Source/WebCore/platform/graphics/gstreamer -I./Source/WebCore/platform/graphics/gtk -I./Source/WebCore/platform/graphics/transforms -I./Source/WebCore/platform/gtk -I./Source/WebCore/platform/image-decoders -I./Source/WebCore/platform/image-decoders/bmp -I./Source/WebCore/platform/image-decoders/cairo -I./Source/WebCore/platform/image-decoders/gif -I./Source/WebCore/platform/image-decoders/ico -I./Source/WebCore/platform/image-decoders/jpeg -I./Source/WebCore/platform/image-decoders/png -I./Source/WebCore/platform/image-decoders/webp -I./Source/WebCore/platform/network -I./Source/WebCore/platform/network/gtk -I./Source/WebCore/platform/network/soup -I./Source/WebCore/platform/text -I./Source/ThirdParty/ANGLE/src -I./Source/ThirdParty/ANGLE/include -I./Source/ThirdParty/ANGLE/include/GLSLANG -I./Source/ThirdParty/ANGLE/include/KHR -I./Source/WebCore -I./Source/WebCore/Modules/battery -I./Source/WebCore/Modules/filesystem -I./Source/WebCore/Modules/gamepad -I./Source/WebCore/Modules/geolocation -I./Source/WebCore/Modules/indexeddb -I./Source/WebCore/Modules/mediasource -I./Source/WebCore/Modules/mediastream -I./Source/WebCore/Modules/navigatorcontentutils -I./Source/WebCore/Modules/notifications -I./Source/WebCore/Modules/proximity -I./Source/WebCore/Modules/quota -I./Source/WebCore/Modules/webaudio -I./Source/WebCore/Modules/webdatabase -I./Source/WebCore/Modules/websockets -I./Source/WebCore/accessibility -I./Source/WebCore/bindings -I./Source/WebCore/bindings/generic -I./Source/WebCore/bindings/js -I./Source/WebCore/bridge -I./Source/WebCore/bridge/c -I./Source/WebCore/bridge/jsc -I./Source/WebCore/css -I./Source/WebCore/dom -I./Source/WebCore/dom/default -I./Source/WebCore/editing -I./Source/WebCore/fileapi -I./Source/WebCore/history -I./Source/WebCore/html -I./Source/WebCore/html/canvas -I./Source/WebCore/html/forms -I./Source/WebCore/html/parser -I./Source/WebCore/html/shadow -I./Source/WebCore/html/track -I./Source/WebCore/inspector -I./Source/WebCore/loader -I./Source/WebCore/loader/appcache -I./Source/WebCore/loader/archive -I./Source/WebCore/loader/archive/mhtml -I./Source/WebCore/loader/cache -I./Source/WebCore/loader/icon -I./Source/WebCore/mathml -I./Source/WebCore/page -I./Source/WebCore/page/animation -I./Source/WebCore/page/scrolling -I./Source/WebCore/platform -I./Source/WebCore/platform/animation -I./Source/WebCore/platform/audio -I./Source/WebCore/platform/graphics -I./Source/WebCore/platform/graphics/cpu/arm -I./Source/WebCore/platform/graphics/cpu/arm/filters/ -I./Source/WebCore/platform/graphics/filters -I./Source/WebCore/platform/graphics/filters/texmap -I./Source/WebCore/platform/graphics/freetype -I./Source/WebCore/platform/graphics/gpu -I./Source/WebCore/platform/graphics/harfbuzz -I./Source/WebCore/platform/graphics/harfbuzz/ng -I./Source/WebCore/platform/graphics/opengl -I./Source/WebCore/platform/graphics/opentype -I./Source/WebCore/platform/graphics/transforms -I./Source/WebCore/platform/image-decoders -I./Source/WebCore/platform/image-decoders/bmp -I./Source/WebCore/platform/image-decoders/gif -I./Source/WebCore/platform/image-decoders/ico -I./Source/WebCore/platform/image-decoders/jpeg -I./Source/WebCore/platform/image-decoders/png -I./Source/WebCore/platform/image-decoders/webp -I./Source/WebCore/platform/leveldb -I./Source/WebCore/platform/linux -I./Source/WebCore/platform/mediastream -I./Source/WebCore/platform/mediastream/gstreamer -I./Source/WebCore/platform/mock -I./Source/WebCore/platform/network -I./Source/WebCore/platform/network/gtk -I./Source/WebCore/platform/sql -I./Source/WebCore/platform/text -I./Source/WebCore/platform/text/transcoder -I./Source/WebCore/platform/win -I./Source/WebCore/plugins -I./Source/WebCore/plugins/win -I./Source/WebCore/rendering -I./Source/WebCore/rendering/mathml -I./Source/WebCore/rendering/style -I./Source/WebCore/rendering/svg -I./Source/WebCore/storage -I./Source/WebCore/svg -I./Source/WebCore/svg/animation -I./Source/WebCore/svg/graphics -I./Source/WebCore/svg/graphics/filters -I./Source/WebCore/svg/properties -I./Source/WebCore/testing -I./Source/WebCore/testing/js -I./Source/WebCore/websockets -I./Source/WebCore/workers -I./Source/WebCore/xml -I./Source/WebCore/xml/parser -I./WebCore/bindings/js -I./DerivedSources/WebCore -I./DerivedSources -I./DerivedSources/JavaScriptCore -I./Source/WebCore/platform/graphics/texmap -DWEBKITGTK_API_VERSION_STRING=\"3.0\" -I./Source/WebCore/accessibility/atk -I./Source/WebCore/loader/gtk -I./Source/WebCore/page/gtk -I./Source/WebCore/platform/cairo -I./Source/WebCore/platform/audio/gstreamer -I./Source/WebCore/platform/graphics/cairo -I./Source/WebCore/platform/graphics/freetype -I./Source/WebCore/platform/graphics/glx -I./Source/WebCore/platform/graphics/harfbuzz -I./Source/WebCore/platform/graphics/harfbuzz/ng -I./Source/WebCore/platform/graphics/egl -I./Source/WebCore/platform/graphics/gstreamer -I./Source/WebCore/platform/graphics/gtk -I./Source/WebCore/platform/gtk -I./Source/WebCore/platform/network/soup -I./Source/WebCore/platform/text/enchant -I./Source -I./Source/JavaScriptCore -I./Source/JavaScriptCore/API -I./Source/JavaScriptCore/assembler -I./Source/JavaScriptCore/bytecode -I./Source/JavaScriptCore/bytecompiler -I./Source/JavaScriptCore/dfg -I./Source/JavaScriptCore/disassembler -I./Source/JavaScriptCore/heap -I./Source/JavaScriptCore/debugger -I./Source/JavaScriptCore/ForwardingHeaders -I./Source/JavaScriptCore/interpreter -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/jit -I./Source/JavaScriptCore/llint -I./Source/JavaScriptCore/parser -I./Source/JavaScriptCore/profiler -I./Source/JavaScriptCore/runtime -I./Source/JavaScriptCore/tools -I./Source/JavaScriptCore/yarr -I./DerivedSources/JavaScriptCore -I./Source/WTF -fno-strict-aliasing -pthread -I/opt/garnome-3.8/include/enchant -I/opt/garnome-3.8/include/glib-2.0 -I/opt/garnome-3.8/lib/glib-2.0/include -I/opt/garnome-3.8/include/cairo -I/opt/garnome-3.8/include/glib-2.0 -I/opt/garnome-3.8/lib/glib-2.0/include -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include/freetype2 -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include/harfbuzz -I/usr/include/pixman-1 -I/usr/include/libpng14 -pthread -I/opt/garnome-3.8/include/gail-3.0 -I/opt/garnome-3.8/include/gtk-3.0 -I/opt/garnome-3.8/include/at-spi2-atk/2.0 -I/opt/garnome-3.8/include/gtk-3.0 -I/opt/garnome-3.8/include/gio-unix-2.0/ -I/opt/garnome-3.8/include/cairo -I/opt/garnome-3.8/include/pango-1.0 -I/opt/garnome-3.8/include/harfbuzz -I/opt/garnome-3.8/include/pango-1.0 -I/opt/garnome-3.8/include/atk-1.0 -I/opt/garnome-3.8/include/cairo -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include/freetype2 -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include/gdk-pixbuf-2.0 -I/opt/garnome-3.8/include/glib-2.0 -I/opt/garnome-3.8/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng14 -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include/dbus-1.0 -I/opt/garnome-3.8/lib/dbus-1.0/include -I/opt/garnome-3.8/include/glib-2.0 -I/opt/garnome-3.8/lib/glib-2.0/include -I/opt/garnome-3.8/include/libxml2 -pthread -I/opt/garnome-3.8/include/glib-2.0 -I/opt/garnome-3.8/lib/glib-2.0/include -pthread -I/opt/garnome-3.8/include/gstreamer-1.0 -I/opt/garnome-3.8/include/glib-2.0 -I/opt/garnome-3.8/lib/glib-2.0/include -pthread -I/opt/garnome-3.8/include/gtk-3.0 -I/opt/garnome-3.8/include/at-spi2-atk/2.0 -I/opt/garnome-3.8/include/gtk-3.0 -I/opt/garnome-3.8/include/gio-unix-2.0/ -I/opt/garnome-3.8/include/cairo -I/opt/garnome-3.8/include/pango-1.0 -I/opt/garnome-3.8/include/harfbuzz -I/opt/garnome-3.8/include/pango-1.0 -I/opt/garnome-3.8/include/atk-1.0 -I/opt/garnome-3.8/include/cairo -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include/freetype2 -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include/gdk-pixbuf-2.0 -I/opt/garnome-3.8/include/glib-2.0 -I/opt/garnome-3.8/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/libpng14 -pthread -I/opt/garnome-3.8/include/libsoup-2.4 -I/opt/garnome-3.8/include/libxml2 -I/opt/garnome-3.8/include/glib-2.0 -I/opt/garnome-3.8/lib/glib-2.0/include -I/opt/garnome-3.8/include/libxml2 -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include/libxml2 -I/opt/garnome-3.8/include -D_REENTRANT -DU_DEBUG=1 -I/opt/garnome-3.8/include -I/opt/garnome-3.8/include -fvisibility-inlines-hidden -fno-rtti -I/opt/garnome-3.8/include -L/opt/garnome-3.8/lib -O2 -pipe -std=c++11 -Wno-c++11-compat -O2 -MT Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-AcceleratedCompositingContextClutter.lo -MD -MP -MF Source/WebKit/gtk/WebCoreSupport/.deps/libwebkitgtk_3_0_la-AcceleratedCompositingContextClutter.Tpo -c Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp  -fPIC -DPIC -o Source/WebKit/gtk/WebCoreSupport/.libs/libwebkitgtk_3_0_la-AcceleratedCompositingContextClutter.o
In file included from /opt/garnome-3.8/include/unicode/uchar.h:26:0,
                 from ./Source/WTF/wtf/unicode/icu/UnicodeIcu.h:29,
                 from ./Source/WTF/wtf/unicode/Unicode.h:32,
                 from ./Source/WTF/wtf/text/ASCIIFastPath.h:31,
                 from ./Source/WTF/wtf/text/WTFString.h:28,
                 from ./Source/WebCore/platform/animation/Animation.h:33,
                 from ./Source/WebCore/platform/graphics/GraphicsLayer.h:31,
                 from Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:22,
                 from Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:21:
/opt/garnome-3.8/include/unicode/utypes.h:402:70: warning: "_MSC_VER" is not defined [-Wundef]
 #if defined(__cplusplus) && U_DEBUG && U_OVERRIDE_CXX_ALLOCATION && (_MSC_VER>=1200) && !defined(U_STATIC_IMPLEMENTATION) && (defined(U_COMMON_IMPLEMENTATION) || defined(U_I18N_IMPLEMENTATION) || defined(U_IO_IMPLEMENTATION) || defined(U_LAYOUT_IMPLEMENTATION) || defined(U_LAYOUTEX_IMPLEMENTATION))
                                                                      ^
In file included from ./Source/WebCore/platform/graphics/Font.h:28:0,
                 from ./Source/WebCore/platform/graphics/GraphicsContext.h:33,
                 from ./Source/WebCore/platform/graphics/texmap/TextureMapper.h:35,
                 from ./Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h:29,
                 from Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContext.h:31,
                 from Source/WebKit/gtk/WebCoreSupport/AcceleratedCompositingContextClutter.cpp:21:
./Source/WebCore/platform/graphics/FontDescription.h:36:35: fatal error: WebKitFontFamilyNames.h: No such file or directory
 #include "WebKitFontFamilyNames.h"
                                   ^
compilation terminated.
make[2]: *** [Source/WebKit/gtk/WebCoreSupport/libwebkitgtk_3_0_la-AcceleratedCo

[Zan Dobersek]

A clean build should fix your problems. Could you try that?

[David Ronis]

This was a clean build (I'd also run  make uninstall in the previous version's directory).   I remember if I'd set a -j make flag in the build that just failed, so I reran; I get the same result.

[David Ronis]

I was able to get webkit built and installed by doing the following on a newly unpacked source tree:

make (which gives the reported error)
make -k (If I run with -j4 I still get errors, but running again with no -j works)
make install

I vaguely remember reporting this "fix" before.

I'm on a slackware box, running a locally maintained garnome gnome and friends.

[Sebastian Dröge (slomo)]

I can confirm that, and it goes away after retrying. Sometimes works with -j5, sometimes with -j1, sometimes doesn't work with either of these. It's just racy somewhere it seems

[Zan Dobersek]

Created attachment 204027 [details]
Patch

[Zan Dobersek]

Comment on attachment 204027 [details]
Patch

Clearing flags on attachment: 204027

Committed r151325: <http://trac.webkit.org/changeset/151325>

[Zan Dobersek]

All reviewed patches have been landed.  Closing bug.