Bug 117166 - Convert a comment about appliedEditing being called directly by TypingCommand to an assertion
Summary: Convert a comment about appliedEditing being called directly by TypingCommand...
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 117165
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-03 14:04 PDT by Ryosuke Niwa
Modified: 2021-09-28 11:16 PDT (History)
6 users (show)

See Also:


Attachments
Adds an assertion (6.91 KB, patch)
2013-06-03 18:02 PDT, Ryosuke Niwa
bfulgham: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (471.56 KB, application/zip)
2013-06-03 22:38 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (1.24 MB, application/zip)
2013-06-04 04:32 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-06-03 14:04:00 PDT
While working on the bug 117165, I've converted the following comment in CompositeEditCommand::apply to an assertion:

    // Only need to call appliedEditing for top-level commands,
    // and TypingCommands do it on their own (see TypingCommand::typingAddedToOpenCommand).
    if (!isTypingCommand())
        frame->editor().appliedEditing(this);

and found a nasty bug where TypingCommand wasn't registering itself to the undo manager in some cases.
Comment 1 Ryosuke Niwa 2013-06-03 17:57:30 PDT
Not quite. My assertion missed one corner case.
Comment 2 Ryosuke Niwa 2013-06-03 18:02:00 PDT
Created attachment 203640 [details]
Adds an assertion
Comment 3 EFL EWS Bot 2013-06-03 19:03:03 PDT
Comment on attachment 203640 [details]
Adds an assertion

Attachment 203640 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/660560
Comment 4 Brent Fulgham 2013-06-03 21:19:32 PDT
Comment on attachment 203640 [details]
Adds an assertion

r=me.  I don't see how the EFL failure is related to this change.
Comment 5 Build Bot 2013-06-03 22:38:55 PDT
Comment on attachment 203640 [details]
Adds an assertion

Attachment 203640 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/700665

New failing tests:
editing/pasteboard/paste-line-endings-002.html
editing/pasteboard/paste-4038267-fix.html
editing/execCommand/4920488.html
editing/pasteboard/paste-line-endings-003.html
http/tests/inspector/inspect-element.html
editing/pasteboard/paste-line-endings-004.html
editing/inserting/insert-empty-html.html
editing/style/iframe-onload-crash-win.html
editing/execCommand/5573879.html
editing/style/iframe-onload-crash-unix.html
editing/deleting/delete-ligature-003.html
editing/pasteboard/smart-paste-001.html
editing/execCommand/19455.html
editing/style/push-down-font-styles-win.html
editing/deleting/delete-before-block-table.html
editing/execCommand/5049671.html
editing/deleting/5847330-1.html
editing/pasteboard/paste-line-endings-005.html
editing/style/push-down-font-styles-mac.html
editing/inserting/space-after-removeformat.html
editing/execCommand/19653-1.html
editing/style/iframe-onload-crash-mac.html
editing/deleting/delete-to-select-table.html
editing/deleting/delete-before-block-image-1.html
editing/undo/orphaned-selection-crash-bug32823-4.html
editing/deleting/delete-by-word-002.html
editing/execCommand/19403.html
Comment 6 Build Bot 2013-06-03 22:38:57 PDT
Created attachment 203652 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 7 Build Bot 2013-06-04 04:32:16 PDT
Comment on attachment 203640 [details]
Adds an assertion

Attachment 203640 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/700746

New failing tests:
editing/pasteboard/paste-line-endings-002.html
editing/pasteboard/paste-4038267-fix.html
editing/execCommand/4920488.html
http/tests/security/mixedContent/redirect-https-to-http-iframe-in-main-frame.html
editing/undo/orphaned-selection-crash-bug32823-2.html
editing/pasteboard/paste-line-endings-003.html
http/tests/inspector/inspect-element.html
fast/forms/input-text-paste-maxlength.html
editing/pasteboard/paste-line-endings-004.html
editing/inserting/insert-empty-html.html
editing/style/iframe-onload-crash-win.html
editing/style/iframe-onload-crash-unix.html
editing/deleting/delete-ligature-003.html
editing/execCommand/19455.html
editing/style/push-down-font-styles-win.html
editing/deleting/delete-before-block-table.html
editing/execCommand/5049671.html
editing/deleting/5847330-1.html
editing/pasteboard/paste-line-endings-005.html
editing/style/push-down-font-styles-mac.html
editing/inserting/space-after-removeformat.html
editing/execCommand/19653-1.html
editing/style/iframe-onload-crash-mac.html
editing/deleting/delete-to-select-table.html
editing/deleting/delete-before-block-image-1.html
editing/undo/orphaned-selection-crash-bug32823-4.html
editing/deleting/delete-by-word-002.html
editing/execCommand/19403.html
Comment 8 Build Bot 2013-06-04 04:32:18 PDT
Created attachment 203680 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.3