Bug 117157 – [GTK][SOUP] Migrate SoupRequestManager to GTask

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

Migrate SoupRequestManager to GTask

[Carlos Garcia Campos]

Created attachment 203602 [details]
Patch

[Chris Dumez]

Comment on attachment 203602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review

> Source/WebKit2/ChangeLog:7
> +

Could you please explain in the Changelog why we are migrating to GTask?

[Gustavo Noronha (kov)]

Comment on attachment 203602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review

I kept wondering if we could do away with the data struct like you did on the other patch, but I don't think there's a lot to gain here.

>> Source/WebKit2/ChangeLog:7
>> +
> 
> Could you please explain in the Changelog why we are migrating to GTask?

++

[Carlos Garcia Campos]

(In reply to comment #3)
> (From update of attachment 203602 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review
> 
> I kept wondering if we could do away with the data struct like you did on the other patch, but I don't think there's a lot to gain here.

In this case the AsyncData struct is not only for the GTask async operation but for the whole custom uri scheme operation. Note that this data struct is not set as task data, but it contains the GTask that is released (see releaseTask) when it finishes.

> >> Source/WebKit2/ChangeLog:7
> >> +
> > 
> > Could you please explain in the Changelog why we are migrating to GTask?
> 
> ++

[Carlos Garcia Campos]

Committed r151726: <http://trac.webkit.org/changeset/151726>