Bug 117157 - [GTK][SOUP] Migrate SoupRequestManager to GTask
Summary: [GTK][SOUP] Migrate SoupRequestManager to GTask
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Soup
Depends on:
Blocks: 117149
  Show dependency tree / graph
 
Reported: 2013-06-03 09:15 PDT by Carlos Garcia Campos
Modified: 2013-06-19 00:34 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.29 KB, patch)
2013-06-03 09:19 PDT, Carlos Garcia Campos 		gustavo: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-06-03 09:15:13 PDT 
Migrate SoupRequestManager to GTask
Comment 1 Carlos Garcia Campos 2013-06-03 09:19:18 PDT 
Created attachment 203602 [details]
Patch
Comment 2 Chris Dumez 2013-06-05 01:14:49 PDT 
Comment on attachment 203602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review

> Source/WebKit2/ChangeLog:7
> +

Could you please explain in the Changelog why we are migrating to GTask?
Comment 3 Gustavo Noronha (kov) 2013-06-17 20:18:19 PDT 
Comment on attachment 203602 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review

I kept wondering if we could do away with the data struct like you did on the other patch, but I don't think there's a lot to gain here.

>> Source/WebKit2/ChangeLog:7
>> +
> 
> Could you please explain in the Changelog why we are migrating to GTask?

++
Comment 4 Carlos Garcia Campos 2013-06-19 00:32:25 PDT 
(In reply to comment #3)
> (From update of attachment 203602 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=203602&action=review
> 
> I kept wondering if we could do away with the data struct like you did on the other patch, but I don't think there's a lot to gain here.

In this case the AsyncData struct is not only for the GTask async operation but for the whole custom uri scheme operation. Note that this data struct is not set as task data, but it contains the GTask that is released (see releaseTask) when it finishes.

> >> Source/WebKit2/ChangeLog:7
> >> +
> > 
> > Could you please explain in the Changelog why we are migrating to GTask?
> 
> ++
Comment 5 Carlos Garcia Campos 2013-06-19 00:34:27 PDT 
Committed r151726: <http://trac.webkit.org/changeset/151726>