Migrate WebKitWebView to GTask
Created attachment 203598 [details] Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment on attachment 203598 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203598&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2472 > + if (g_cancellable_set_error_if_cancelled(g_task_get_cancellable(task.get()), &error)) { > + g_task_return_error(task.get(), error); > + return; > + } if (g_task_return_error_if_cancelled(task)) return; > Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:2953 > + if (g_cancellable_set_error_if_cancelled(g_task_get_cancellable(task.get()), &error)) { likewise
Created attachment 203664 [details] Updated patch according to review comments
Comment on attachment 203664 [details] Updated patch according to review comments looks good
Comment on attachment 203664 [details] Updated patch according to review comments LGTM
Committed r151724: <http://trac.webkit.org/changeset/151724>