Bug 117145 – REGRESSION(r151109): "Plugins in WK2 aren't implemented yet." (Requested by jturcotte on #webkit).

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Commit Bot]

http://trac.webkit.org/changeset/151109 broke the build:
"Plugins in WK2 aren't implemented yet." (Requested by jturcotte on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Commit Bot]

Created attachment 203584 [details]
ROLLOUT of r151109

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[WebKit Commit Bot]

Comment on attachment 203584 [details]
ROLLOUT of r151109

Clearing flags on attachment: 203584

Committed r151111: <http://trac.webkit.org/changeset/151111>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Comment on attachment 203584 [details]
ROLLOUT of r151109

View in context: https://bugs.webkit.org/attachment.cgi?id=203584&action=review

> Source/WebCore/plugins/mac/PluginPackageMac.cpp:141
> -        WTF::RetainPtr<CFStringRef> homeDir = homeDirectoryPath().createCFString();
> +        WTF::RetainPtr<CFStringRef> homeDir = adoptCF(homeDirectoryPath().createCFString());

This was fine.

> Source/WebCore/plugins/mac/PluginPackageMac.cpp:258
> -    WTF::RetainPtr<CFStringRef> path = m_path.createCFString();
> +    WTF::RetainPtr<CFStringRef> path = adoptCF(m_path.createCFString());

Ditto.