Bug 117142 - Remove 'activeSourceCount' from AudioContext and 'playbackState' from AudioBufferSourceNode and OscillatorNode IDLs.
Summary: Remove 'activeSourceCount' from AudioContext and 'playbackState' from AudioBu...
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2013-06-03 05:32 PDT by Praveen Jadhav
Modified: 2022-02-28 00:07 PST (History)
9 users (show)

See Also:

Attachments
Patch (9.00 KB, patch)
2013-06-03 06:28 PDT, Praveen Jadhav 		no flags Details | Formatted Diff | Diff
Patch (19.90 KB, patch)
2013-06-04 05:05 PDT, Praveen Jadhav 		no flags Details | Formatted Diff | Diff
Updated patch (19.88 KB, patch)
2013-10-17 05:04 PDT, Praveen Jadhav 		beidson: review-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Praveen Jadhav 2013-06-03 05:32:09 PDT 
Attribute 'activeSourceCount' is insignificant especially after including 'onended' events in source nodes. It has been removed from latest WebAudio spec https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioContext-section.
Comment 1 Praveen Jadhav 2013-06-03 06:28:53 PDT 
Created attachment 203581 [details]
Patch
Comment 2 Chris Dumez 2013-06-03 06:40:34 PDT 
Comment on attachment 203581 [details]
Patch

LGTM.
Comment 3 Chris Rogers 2013-06-03 10:42:46 PDT 
Comment on attachment 203581 [details]
Patch

Thanks Praveen, we might as well also remove the .playbackState attribute, then we can remove the layout test completely.

We should write a more detailed test to replace it, using onended events
Comment 4 Praveen Jadhav 2013-06-04 05:05:29 PDT 
Created attachment 203683 [details]
Patch

Thanks Chris for the update. I have updated the code as per the comments. State machine in AudioScheduledSourceNode are not exposed to JS but retained for internal operations.
Comment 5 Praveen Jadhav 2013-10-17 05:04:47 PDT 
Created attachment 214443 [details]
Updated patch

Code updated.
Comment 6 Csaba Osztrogonác 2014-02-13 04:04:48 PST 
Comment on attachment 203581 [details]
Patch

Cleared Chris Rogers's review+ from obsolete attachment 203581 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 7 Brady Eidson 2016-05-24 22:03:31 PDT 
Comment on attachment 214443 [details]
Updated patch

Assuming that patches for review since 2013 are stale, r-