Bug 117131 - [WTF] Add OwnArrayPtr vectortraits template
Summary: [WTF] Add OwnArrayPtr vectortraits template
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 105156
  Show dependency tree / graph
 
Reported: 2013-06-02 22:11 PDT by Gyuyoung Kim
Modified: 2013-06-03 00:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.41 KB, patch)
2013-06-02 22:14 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-06-02 22:11:43 PDT 
Bug 105156 needs to use Vector<OwnArrayPtr<char>>. So, we need to add OwnArrayPtr to VectorTraits, which was guided in https://bugs.webkit.org/show_bug.cgi?id=105156#c39
Comment 1 Gyuyoung Kim 2013-06-02 22:14:05 PDT 
Created attachment 203553 [details]
Patch
Comment 2 Gyuyoung Kim 2013-06-02 22:14:55 PDT 
CC'ing Darin
Comment 3 Darin Adler 2013-06-02 23:05:04 PDT 
Comment on attachment 203553 [details]
Patch

Looks OK. Might slow down compiles a bit since we are now including OwnArrayPtr in a lot of places that we weren’t before.
Comment 4 Gyuyoung Kim 2013-06-02 23:53:36 PDT 
(In reply to comment #3)
> (From update of attachment 203553 [details])
> Looks OK. Might slow down compiles a bit since we are now including OwnArrayPtr in a lot of places that we weren’t before.

Thank you for review. It seems to me that this patch won't great influence on build time.
Comment 5 WebKit Commit Bot 2013-06-03 00:09:53 PDT 
Comment on attachment 203553 [details]
Patch

Clearing flags on attachment: 203553

Committed r151093: <http://trac.webkit.org/changeset/151093>
Comment 6 WebKit Commit Bot 2013-06-03 00:09:57 PDT 
All reviewed patches have been landed.  Closing bug.