Bug 117117 – Unstyled XML viewer crashes when XML contains an element with id="tree"

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector (Deprecated)

[Alexey Proskuryakov]

XML tree viewer that is used for unstyled XML combines the document with additional content, and then uses document.getElementById to find the additional content.

This doesn't work correctly when the XML viewed has conflicting IDs.

<rdar://problem/13727267>

[Alexey Proskuryakov]

Created attachment 203502 [details]
proposed fix

This was done in such a strange way because there were Chromium extensions that duplicated this functionality, and Chromium folks wanted to give those a way to override built-in implementation.

I could not find such extensions on extensions.apple.com. And in any case, I don't think that this is the approach we'd have taken if we wanted extensions to have this ability.

[Darin Adler]

Comment on attachment 203502 [details]
proposed fix

OK.

[Build Bot]

Comment on attachment 203502 [details]
proposed fix

Attachment 203502 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/765039

New failing tests:
xmlviewer/extensions-api.html

[Build Bot]

Created attachment 203506 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3

[Alexey Proskuryakov]

Created attachment 203508 [details]
patch for landing

Oh good, I didn't find this test myself. Removing it, as the changes were intentional.

[WebKit Commit Bot]

Comment on attachment 203508 [details]
patch for landing

Clearing flags on attachment: 203508

Committed r151080: <http://trac.webkit.org/changeset/151080>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.