RESOLVED FIXED 117104
Move Node::hasID() and hasClass() to Element. 
https://bugs.webkit.org/show_bug.cgi?id=117104
Summary Move Node::hasID() and hasClass() to Element.
Andreas Kling
Reported 2013-06-01 00:35:53 PDT
Move Node::hasID() and hasClass() to Element.
Attachments
Patch (8.78 KB, patch)
2013-06-01 00:43 PDT, Andreas Kling 		rniwa: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-06-01 00:43:29 PDT
Created attachment 203481 [details] Patch
Ryosuke Niwa
Comment 2 2013-06-01 02:12:13 PDT
Comment on attachment 203481 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=203481&action=review > Source/WebCore/dom/LiveNodeList.cpp:114 > + if (!node->isElementNode()) > + continue; Only ChildNodeList contains non-element item so maybe we want to check that condition outside the loop instead. We don't need to do this in this patch though. > Source/WebCore/rendering/RenderLayer.cpp:283 > + if (Element* element = renderer()->node() && renderer()->node()->isElementNode() ? toElement(renderer()->node()) : 0) { Looks like we almost want renderer()->element().
Andreas Kling
Comment 3 2013-06-01 02:40:07 PDT
Committed r151069: <http://trac.webkit.org/changeset/151069>
Note You need to log in before you can comment on or make changes to this bug.