Bug 117104 - Move Node::hasID() and hasClass() to Element.
Summary: Move Node::hasID() and hasClass() to Element.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-01 00:35 PDT by Andreas Kling
Modified: 2013-06-01 02:40 PDT (History)
7 users (show)

See Also:

Attachments
Patch (8.78 KB, patch)
2013-06-01 00:43 PDT, Andreas Kling 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-06-01 00:35:53 PDT 
Move Node::hasID() and hasClass() to Element.
Comment 1 Andreas Kling 2013-06-01 00:43:29 PDT 
Created attachment 203481 [details]
Patch
Comment 2 Ryosuke Niwa 2013-06-01 02:12:13 PDT 
Comment on attachment 203481 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203481&action=review

> Source/WebCore/dom/LiveNodeList.cpp:114
> +        if (!node->isElementNode())
> +            continue;

Only ChildNodeList contains non-element item so maybe we want to check that condition outside the loop instead.
We don't need to do this in this patch though.

> Source/WebCore/rendering/RenderLayer.cpp:283
> +    if (Element* element = renderer()->node() && renderer()->node()->isElementNode() ? toElement(renderer()->node()) : 0) {

Looks like we almost want renderer()->element().
Comment 3 Andreas Kling 2013-06-01 02:40:07 PDT 
Committed r151069: <http://trac.webkit.org/changeset/151069>