Bug 11710 - REGRESSION (r17906): Crash in WebCore::FrameMac
Summary: REGRESSION (r17906): Crash in WebCore::FrameMac
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P1 Normal
Assignee: Geoffrey Garen
Keywords: Regression
Depends on:
Reported: 2006-11-28 20:06 PST by Matt Lilek
Modified: 2006-11-29 14:25 PST (History)
3 users (show)

See Also:

Crashlog (20.12 KB, text/plain)
2006-11-28 20:06 PST, Matt Lilek
no flags Details
Fix w/changelog (13.04 KB, patch)
2006-11-29 13:55 PST, Geoffrey Garen
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2006-11-28 20:06:09 PST
Create a selection on a page, then close that tab/window - WebKit go boom.

Regressed between 17902 and 17915.
Comment 1 Matt Lilek 2006-11-28 20:06:43 PST
Created attachment 11662 [details]
Comment 2 Kevin M. Dean 2006-11-28 20:25:29 PST
I can confirm that I getting the same crashes.
Comment 3 mitz 2006-11-28 22:33:58 PST
My local build is r17906 and has this bug. I suspect it was introduced in r17906.
Comment 4 mitz 2006-11-28 23:20:28 PST
        if (editor()->client()->isContinuousSpellCheckingEnabled()) {

The editor client is 0 since the page is being destroyed.
Comment 5 Geoffrey Garen 2006-11-29 08:38:58 PST
Sounds right to me. It's really lame that we have to NULL check clients (and only some clients, at that). I wonder if we can come up with a better solution.
Comment 6 Geoffrey Garen 2006-11-29 12:05:18 PST
I'll take this one.
Comment 7 Geoffrey Garen 2006-11-29 13:55:25 PST
Created attachment 11673 [details]
Fix w/changelog
Comment 8 mitz 2006-11-29 14:08:32 PST
Comment on attachment 11673 [details]
Fix w/changelog

"Editor::" is redundant here:
+    NSString* Editor::_web_userVisibleString(NSURL* nsURL);
Comment 9 Geoffrey Garen 2006-11-29 14:25:52 PST
Committed revision 17930.