DeprecatedString::format is broken on windows

[Darin Fisher (:fishd, Google)]

DeprecatedString::format is broken on windows

DeprecatedString::setNum(99) for example fails to set the contents of the string to "99".  What's going on is that the initial call to vsnprintf fails, and so the string is assigned an empty value.

[Darin Fisher (:fishd, Google)]

There's a comment saying that the code from String::format should be duplicated for DeprecatedString::format!  Is that still the plan?

This bug causes things like "window.location.href" to report an URL that is lacking the port number, which causes some pages not to work properly.

[Darin Fisher (:fishd, Google)]

By the way, I think the correct solution is to use _vscprintf instead of calling vsnprintf in a loop like String::format does.  Patch coming up...

[Darin Fisher (:fishd, Google)]

Created attachment 11661 [details]
patch

Use _vscprintf in both places.

[Darin Fisher (:fishd, Google)]

By the way, the documentation for _vscprintf is here:
http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/vclrf_vscprintf_vscwprintf.asp

[Darin Adler]

Comment on attachment 11661 [details]
patch

Looks great, r=me.

[Alexey Proskuryakov]

Committed revision 17985.