Bug 117076 - Don't create an accelerated compositing layer unless we have to for snapshotting plug-ins
Summary: Don't create an accelerated compositing layer unless we have to for snapshott...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-31 08:14 PDT by Dean Jackson
Modified: 2013-05-31 11:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (5.18 KB, patch)
2013-05-31 08:19 PDT, Dean Jackson 		bdakin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-05-31 08:14:53 PDT 
https://bugs.webkit.org/show_bug.cgi?id=116490 changed the way snapshotting plugins can use accelerated compositing, allowing them to start in that mode before snapshotting. It turns out that this isn't a great user experience. So, for plugins that we know can support software-snapshotting, don't put them in compositing mode.

<rdar://problem/14030364>
Comment 1 Dean Jackson 2013-05-31 08:19:06 PDT 
Created attachment 203448 [details]
Patch
Comment 2 Dean Jackson 2013-05-31 09:46:10 PDT 
Comments from Anders on IRC:

- don't put the MIMETypeRegistry method in
- use == rather than startsWith
Comment 3 Dean Jackson 2013-05-31 10:04:48 PDT 
Committed r151026: <http://trac.webkit.org/changeset/151026>
Comment 4 Sam Weinig 2013-05-31 11:10:17 PDT 
What exactly is broken here?  You say that it "isn't a great user experience", but what does that mean? Can't we always use the CA path rather than the software snapshotting?