Bug 117066 - [sh4] Fix floating point comparisons in baseline JIT
Summary: [sh4] Fix floating point comparisons in baseline JIT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-31 02:32 PDT by Julien Brianceau
Modified: 2013-05-31 11:22 PDT (History)
2 users (show)

See Also:

Attachments
Fix floating point comparisons in sh4 baseline JIT (10.86 KB, patch)
2013-05-31 02:51 PDT, Julien Brianceau 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Brianceau 2013-05-31 02:32:01 PDT 
Current implementation of branchDouble function in baseline JIT is wrong for some conditions (1) and overkill for others (2).

(1) With DoubleGreaterThanOrEqual condition for instance, branch will be taken if either operand is NaN with current implementation whereras it should not.
(2) With DoubleNotEqualOrUnordered condition for instance, performed NaN checks are useless (because comparison result is false if either operand is NaN).
Comment 1 Julien Brianceau 2013-05-31 02:51:30 PDT 
Created attachment 203428 [details]
Fix floating point comparisons in sh4 baseline JIT
Comment 2 WebKit Commit Bot 2013-05-31 11:21:58 PDT 
Comment on attachment 203428 [details]
Fix floating point comparisons in sh4 baseline JIT

Clearing flags on attachment: 203428

Committed r151032: <http://trac.webkit.org/changeset/151032>
Comment 3 WebKit Commit Bot 2013-05-31 11:22:01 PDT 
All reviewed patches have been landed.  Closing bug.