Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste.
Created attachment 203425 [details] patch
Comment on attachment 203425 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review This patch looks like a nice step in the right direction. Please add a little context in the ChangeLog so someone reading that file will have a better idea what this change was for. > Source/WebCore/ChangeLog:11 > + (WebCore::Editor::newGeneralClipboard): Please add a note here describing what is changed. > Source/WebCore/ChangeLog:13 > + (WebCore::Pasteboard::createForCopyAndPaste): Ditto.
Created attachment 203551 [details] patch
(In reply to comment #2) > (From update of attachment 203425 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review > > This patch looks like a nice step in the right direction. Please add a little context in the ChangeLog so someone reading that file will have a better idea what this change was for. > > > Source/WebCore/ChangeLog:11 > > + (WebCore::Editor::newGeneralClipboard): > > Please add a note here describing what is changed. > Done > > Source/WebCore/ChangeLog:13 > > + (WebCore::Pasteboard::createForCopyAndPaste): > > Ditto. Done
Brent, please review this patch again, thanks.
Comment on attachment 203551 [details] patch Clearing flags on attachment: 203551 Committed r151253: <http://trac.webkit.org/changeset/151253>
All reviewed patches have been landed. Closing bug.