RESOLVED FIXED 117064
[WIN]Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste. 
https://bugs.webkit.org/show_bug.cgi?id=117064
Summary [WIN]Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste.
huangxueqing
Reported 2013-05-31 01:41:58 PDT
Move "OleGetClipboard" to Pasteboard::createForCopyAndPaste.
Attachments
patch (2.72 KB, patch)
2013-05-31 02:11 PDT, huangxueqing 		bfulgham: review+
DetailsFormatted DiffDiff
patch (2.86 KB, patch)
2013-06-02 19:10 PDT, huangxueqing 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
huangxueqing
Comment 1 2013-05-31 02:11:04 PDT
Created attachment 203425 [details] patch
Brent Fulgham
Comment 2 2013-05-31 22:38:55 PDT
Comment on attachment 203425 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review This patch looks like a nice step in the right direction. Please add a little context in the ChangeLog so someone reading that file will have a better idea what this change was for. > Source/WebCore/ChangeLog:11 > + (WebCore::Editor::newGeneralClipboard): Please add a note here describing what is changed. > Source/WebCore/ChangeLog:13 > + (WebCore::Pasteboard::createForCopyAndPaste): Ditto.
huangxueqing
Comment 3 2013-06-02 19:10:15 PDT
Created attachment 203551 [details] patch
huangxueqing
Comment 4 2013-06-02 19:11:02 PDT
(In reply to comment #2) > (From update of attachment 203425 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=203425&action=review > > This patch looks like a nice step in the right direction. Please add a little context in the ChangeLog so someone reading that file will have a better idea what this change was for. > > > Source/WebCore/ChangeLog:11 > > + (WebCore::Editor::newGeneralClipboard): > > Please add a note here describing what is changed. > Done > > Source/WebCore/ChangeLog:13 > > + (WebCore::Pasteboard::createForCopyAndPaste): > > Ditto. Done
huangxueqing
Comment 5 2013-06-05 19:03:36 PDT
Brent, please review this patch again, thanks.
WebKit Commit Bot
Comment 6 2013-06-05 21:13:06 PDT
Comment on attachment 203551 [details] patch Clearing flags on attachment: 203551 Committed r151253: <http://trac.webkit.org/changeset/151253>
WebKit Commit Bot
Comment 7 2013-06-05 21:13:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.