[GTK] Weird behaviour and no clues to the user when the shared memory file can't be opened

[Enrique Ocaña]

When running a non-debug build of Gtk MiniBrowser, I can only see a big grey rectangle in the place where the web content should be. If I press right click at some place in the grey area, I can see different context menus depending on the contents that should be there if the browser worked properly. No clue about what's causing the behaviour.

After some investigation, gathered some important facts:

- I was running MiniBrowser in a chroot environment
- That chroot environment didn't have /dev/shm or /run/shm mounted
- The actual problem was in this piece of code from SharedMemory::create(), in Source/WebKit2/Platform/unix/SharedMemoryUnix.cpp:

    fileDescriptor = shm_open(tempName.data(), O_CREAT | O_CLOEXEC | O_RDWR, S_IRUSR | S_IWUSR);
    ...
    if (fileDescriptor == -1) {
      return 0;
    }

The real issue is that the user using a normal build has no clue at all about what's causing the problem.

[Enrique Ocaña]

Created attachment 203422 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 203422 [details]
Patch

LGTM

[WebKit Commit Bot]

Comment on attachment 203422 [details]
Patch

Clearing flags on attachment: 203422

Committed r151324: <http://trac.webkit.org/changeset/151324>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.