RESOLVED WONTFIX 117060
Made CodeType an enum class, and removed StackFrameCodeType. 
https://bugs.webkit.org/show_bug.cgi?id=117060
Summary Made CodeType an enum class, and removed StackFrameCodeType.
Mark Lam
Reported 2013-05-30 21:41:56 PDT
Also added CodeType::Invalid and CodeType::Native (for used in stack iteration code later).
Attachments
the patch. (36.22 KB, patch)
2013-05-30 21:50 PDT, Mark Lam 		oliver: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2013-05-30 21:50:54 PDT
Created attachment 203408 [details] the patch.
Oliver Hunt
Comment 2 2013-05-31 09:58:09 PDT
Comment on attachment 203408 [details] the patch. While i appreciate the desire to have a single enum representing the code type in a code block vs. in a stack frame, I don't think it is the right thing to do as it means it will look like a CodeBlock could have "Native" or "Invalid" code types which is clearly bogus.
Mark Lam
Comment 3 2013-05-31 10:15:51 PDT
Very well. I will stick with 2 enums for the 2 purposes then.
Filip Pizlo
Comment 4 2013-05-31 10:51:40 PDT
(In reply to comment #2) > (From update of attachment 203408 [details]) > While i appreciate the desire to have a single enum representing the code type in a code block vs. in a stack frame, I don't think it is the right thing to do as it means it will look like a CodeBlock could have "Native" or "Invalid" code types which is clearly bogus. +1. I like the two enums also.
Note You need to log in before you can comment on or make changes to this bug.