Bug 117048 - fourthTier: LLInt shouldn't store an offset call PC during op_call-like calls
Summary: fourthTier: LLInt shouldn't store an offset call PC during op_call-like calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 117047
  Show dependency treegraph
 
Reported: 2013-05-30 14:54 PDT by Filip Pizlo
Modified: 2013-05-30 16:29 PDT (History)
7 users (show)

See Also:


Attachments
the patch (15.05 KB, patch)
2013-05-30 16:05 PDT, Filip Pizlo
mhahnenberg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2013-05-30 14:54:46 PDT
It should be consistent: the PC that it stores into ArgumentCount + TagOffset should always be the *current* PC.

This allows us to kill off a bunch of nasty code, and it should also make it easier to have dispatchAfterCall() do the job previously done by op_call_put_result.
Comment 1 Filip Pizlo 2013-05-30 16:05:39 PDT
Created attachment 203390 [details]
the patch
Comment 2 Mark Hahnenberg 2013-05-30 16:12:07 PDT
Comment on attachment 203390 [details]
the patch

r=me
Comment 3 Filip Pizlo 2013-05-30 16:29:59 PDT
Landed in http://trac.webkit.org/changeset/150993