Bug 117042 - REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility
Summary: REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the in...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 12:59 PDT by Anders Carlsson
Modified: 2013-05-30 13:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.51 KB, patch)
2013-05-30 13:03 PDT, Anders Carlsson 		mrowe: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-05-30 12:59:55 PDT 
REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility
Comment 1 Anders Carlsson 2013-05-30 13:03:26 PDT 
Created attachment 203377 [details]
Patch
Comment 2 Mark Rowe (bdash) 2013-05-30 13:34:13 PDT 
Comment on attachment 203377 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203377&action=review

> Source/WebCore/loader/cache/CachedScript.cpp:116
> +    // The installer in question tries to load .js file that doesn't exist,/ causing the server to

There's a stray slash in this comment.

> Source/WebCore/platform/RuntimeApplicationChecks.cpp:114
> +    static bool isSolidStateNetworksDownloader = mainBundleIsEqualTo("com.solidstatenetworks.awkhost");
> +    return isSolidStateNetworksDownloader;

I'm not too keen on application specific hacks that never expire. With this hack in place they'd never notice the problem themselves and would have a hard time testing any fix on their end.
Comment 3 Mark Rowe (bdash) 2013-05-30 13:39:34 PDT 
Comment on attachment 203377 [details]
Patch

r=me anyway since I don't have any good ideas on how we could target the app specific hack more narrowly either.
Comment 4 Anders Carlsson 2013-05-30 13:49:48 PDT 
Committed r150977: <http://trac.webkit.org/changeset/150977>