Bug 117040 - Resolve generic families without FontSelector
Summary: Resolve generic families without FontSelector
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 12:13 PDT by Antti Koivisto
Modified: 2013-10-02 12:29 PDT (History)
11 users (show)

See Also:

Attachments
pathc (27.94 KB, patch)
2013-05-30 12:36 PDT, Antti Koivisto 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
patch2 (29.29 KB, patch)
2013-05-31 01:35 PDT, Antti Koivisto 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
patch3 (28.65 KB, patch)
2013-05-31 01:49 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
with CanvasRenderingContext2D fix (33.78 KB, patch)
2013-05-31 03:21 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (508.79 KB, application/zip)
2013-05-31 05:13 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (525.88 KB, application/zip)
2013-05-31 18:01 PDT, Build Bot 		no flags Details
another for bots (35.60 KB, patch)
2013-06-03 06:53 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (526.56 KB, application/zip)
2013-06-03 07:51 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (532.85 KB, application/zip)
2013-06-03 08:13 PDT, Build Bot 		no flags Details
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-05-30 12:13:59 PDT 
FontSelector should only be needed for resolving fonts the reference CSS @font-face rules.
Comment 1 Antti Koivisto 2013-05-30 12:36:57 PDT 
Created attachment 203375 [details]
pathc
Comment 2 Early Warning System Bot 2013-05-30 12:44:17 PDT 
Comment on attachment 203375 [details]
pathc

Attachment 203375 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/742413
Comment 3 Early Warning System Bot 2013-05-30 12:44:22 PDT 
Comment on attachment 203375 [details]
pathc

Attachment 203375 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/744493
Comment 4 EFL EWS Bot 2013-05-30 12:46:06 PDT 
Comment on attachment 203375 [details]
pathc

Attachment 203375 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/740189
Comment 5 EFL EWS Bot 2013-05-30 12:46:21 PDT 
Comment on attachment 203375 [details]
pathc

Attachment 203375 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/742414
Comment 6 Build Bot 2013-05-30 13:00:59 PDT 
Comment on attachment 203375 [details]
pathc

Attachment 203375 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/732088
Comment 7 Antti Koivisto 2013-05-31 01:35:36 PDT 
Created attachment 203421 [details]
patch2
Comment 8 EFL EWS Bot 2013-05-31 01:41:55 PDT 
Comment on attachment 203421 [details]
patch2

Attachment 203421 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/652718
Comment 9 Early Warning System Bot 2013-05-31 01:42:54 PDT 
Comment on attachment 203421 [details]
patch2

Attachment 203421 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/699198
Comment 10 Early Warning System Bot 2013-05-31 01:44:03 PDT 
Comment on attachment 203421 [details]
patch2

Attachment 203421 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/716312
Comment 11 EFL EWS Bot 2013-05-31 01:44:35 PDT 
Comment on attachment 203421 [details]
patch2

Attachment 203421 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/716313
Comment 12 Antti Koivisto 2013-05-31 01:49:29 PDT 
Created attachment 203423 [details]
patch3
Comment 13 Antti Koivisto 2013-05-31 03:21:31 PDT 
Created attachment 203429 [details]
with CanvasRenderingContext2D fix
Comment 14 WebKit Commit Bot 2013-05-31 03:23:42 PDT 
Attachment 203429 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSFontSelector.h', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.h', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontCache.h', u'Source/WebCore/platform/graphics/FontGenericFamilies.cpp', u'Source/WebCore/platform/graphics/FontGenericFamilies.h', u'Source/WebCore/platform/graphics/FontGlyphs.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontSelector.h']" exit_code: 1
Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 15 Build Bot 2013-05-31 05:13:12 PDT 
Comment on attachment 203429 [details]
with CanvasRenderingContext2D fix

Attachment 203429 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/693396

New failing tests:
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
svg/custom/resource-invalidation-crash.svg
Comment 16 Build Bot 2013-05-31 05:13:15 PDT 
Created attachment 203436 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 17 Andreas Kling 2013-05-31 08:27:30 PDT 
Legit failures due to SVG fonts?
Comment 18 Build Bot 2013-05-31 18:01:28 PDT 
Comment on attachment 203429 [details]
with CanvasRenderingContext2D fix

Attachment 203429 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/653660

New failing tests:
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
transitions/font-family-during-transition.html
svg/custom/resource-invalidation-crash.svg
Comment 19 Build Bot 2013-05-31 18:01:33 PDT 
Created attachment 203476 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.3
Comment 20 Antti Koivisto 2013-06-03 06:53:43 PDT 
Created attachment 203583 [details]
another for bots
Comment 21 WebKit Commit Bot 2013-06-03 06:55:01 PDT 
Attachment 203583 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/css/CSSFontSelector.cpp', u'Source/WebCore/css/CSSFontSelector.h', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.h', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', u'Source/WebCore/platform/graphics/Font.cpp', u'Source/WebCore/platform/graphics/Font.h', u'Source/WebCore/platform/graphics/FontCache.cpp', u'Source/WebCore/platform/graphics/FontCache.h', u'Source/WebCore/platform/graphics/FontGenericFamilies.cpp', u'Source/WebCore/platform/graphics/FontGenericFamilies.h', u'Source/WebCore/platform/graphics/FontGlyphs.cpp', u'Source/WebCore/platform/graphics/FontGlyphs.h', u'Source/WebCore/platform/graphics/FontSelector.h', u'Source/WebCore/rendering/style/RenderStyle.cpp']" exit_code: 1
Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:271:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/platform/graphics/Font.h:104:  The parameter name "genericFamilies" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Build Bot 2013-06-03 07:51:46 PDT 
Comment on attachment 203583 [details]
another for bots

Attachment 203583 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/665809

New failing tests:
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
svg/custom/resource-invalidation-crash.svg
Comment 23 Build Bot 2013-06-03 07:51:48 PDT 
Created attachment 203588 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.3
Comment 24 Build Bot 2013-06-03 08:13:02 PDT 
Comment on attachment 203583 [details]
another for bots

Attachment 203583 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/747399

New failing tests:
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
svg/custom/resource-invalidation-crash.svg
Comment 25 Build Bot 2013-06-03 08:13:06 PDT 
Created attachment 203591 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.3