WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
Bug 117035
[Qt][WK1] Hover tests are flaky on Qt when running multiple tests at once
https://bugs.webkit.org/show_bug.cgi?id=117035
Summary
[Qt][WK1] Hover tests are flaky on Qt when running multiple tests at once
Zoltan Arvai
Reported
2013-05-30 08:59:07 PDT
On Qt WK1 fast/regions/hover-on-child-parent-different-regions.html failing after
r150868
. --- /ramdisk/qt-linux-release/build/layout-test-results/fast/regions/hover-on-child-parent-different-regions-expected.txt +++ /ramdisk/qt-linux-release/build/layout-test-results/fast/regions/hover-on-child-parent-different-regions-actual.txt @@ -2,8 +2,8 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS Child hover event processed OK. -PASS Parent hover event processed OK. +FAIL Child hover event FAILED to process. +FAIL Parent hover event FAILED to process. PASS successfullyParsed is true TEST COMPLETE And other tests related to that revision are flaky: fast/regions/hover-on-child-in-region.html fast/regions/hover-in-region-grandparent.html fast/regions/hover-in-region-parent-skip-inlines-anonymous.html
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r150964%20%2851391%29/results.html
It seems these test are fine on Qt WK2.
Attachments
Patch
(6.10 KB, patch)
2013-06-03 02:07 PDT
,
Radu Stavila
no flags
Details
Formatted Diff
Diff
Patch
(1.45 KB, patch)
2013-06-03 09:46 PDT
,
Radu Stavila
no flags
Details
Formatted Diff
Diff
Patch
(1.39 KB, patch)
2013-06-03 10:12 PDT
,
Radu Stavila
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radu Stavila
Comment 1
2013-06-03 02:07:32 PDT
Created
attachment 203562
[details]
Patch Wasn't able to reproduce the problem on my Qt WK1 environment. I modified the test to overcome a possible issue with the hover check being carried out before the hover event could fire. If this patch will fix the main failing test, I will perform the same change for the other flaky tests.
WebKit Commit Bot
Comment 2
2013-06-03 05:52:44 PDT
Comment on
attachment 203562
[details]
Patch Clearing flags on attachment: 203562 Committed
r151104
: <
http://trac.webkit.org/changeset/151104
>
WebKit Commit Bot
Comment 3
2013-06-03 05:52:46 PDT
All reviewed patches have been landed. Closing bug.
Zoltan Arvai
Comment 4
2013-06-03 06:08:55 PDT
fast/regions/hover-on-child-parent-different-regions.html unskipped in
http://trac.webkit.org/changeset/151105
.
Csaba Osztrogonác
Comment 5
2013-06-03 08:34:13 PDT
Reopen, because it still fails: --- /ramdisk/qt-linux-64-release/build/layout-test-results/fast/regions/hover-on-child-parent-different-regions-expected.txt +++ /ramdisk/qt-linux-64-release/build/layout-test-results/fast/regions/hover-on-child-parent-different-regions-actual.txt @@ -1,4 +1,4 @@ -PASS Child hover event processed OK. +FAIL Child hover event FAILED to process. PASS Parent hover event processed OK.
Radu Stavila
Comment 6
2013-06-03 09:46:07 PDT
Created
attachment 203607
[details]
Patch The hover event seems to be triggered only AFTER the results are checked. Forced a re-layout in an attempt to fix this.
Radu Stavila
Comment 7
2013-06-03 10:12:32 PDT
Created
attachment 203611
[details]
Patch Forced relayout to ensure hover event gets called before checking the results.
Csaba Osztrogonác
Comment 8
2013-06-03 10:26:27 PDT
Something is wrong ... fast/regions/hover-on-child-parent-different-regions.html passes for me locally, but it fails on the bot. (I haven't run all the tests, only this one and then all fast/regions tests) Additionally fast/regions/hover-in-second-region.html fails if I run all fast/regions test, but passes if I run only this one. --> expected: 7xx is red, actual: 7xx is blue It seems it needs more debugging ... but now I have to go.
Alexandru Chiculita
Comment 9
2013-06-03 11:11:48 PDT
Comment on
attachment 203611
[details]
Patch Let's see if this fixes the problem on the bots.
WebKit Commit Bot
Comment 10
2013-06-03 11:33:12 PDT
Comment on
attachment 203611
[details]
Patch Clearing flags on attachment: 203611 Committed
r151121
: <
http://trac.webkit.org/changeset/151121
>
WebKit Commit Bot
Comment 11
2013-06-03 11:33:14 PDT
All reviewed patches have been landed. Closing bug.
Zoltan Arvai
Comment 12
2013-06-04 07:50:36 PDT
Still flaky, fails on
http://build.webkit.sed.hu/results/x86-64%20Linux%20Qt%20Release/r151168%20%2851497%29/results.html
Skipped again in
http://trac.webkit.org/changeset/151171
.
Radu Stavila
Comment 13
2013-06-10 01:20:10 PDT
Probably the same issue as
https://bugs.webkit.org/show_bug.cgi?id=117338
Looks like the Qt testing environment has some problems when running multiple hover tests in parallel (probably the multiple simultaneous calls to mouseMoveTo interfere with each other).
Radu Stavila
Comment 14
2013-06-10 01:34:29 PDT
***
Bug 117338
has been marked as a duplicate of this bug. ***
Allan Sandfeld Jensen
Comment 15
2013-06-10 02:06:05 PDT
I think part of the problem is that mouse-move events are not flushed in EventSenderQt.
Jocelyn Turcotte
Comment 16
2014-02-03 03:25:52 PST
=== Bulk closing of Qt bugs === If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary. If you believe that this is still an important QtWebKit bug, please fill a new report at
https://bugreports.qt-project.org
and add a link to this issue. See
http://qt-project.org/wiki/ReportingBugsInQt
for additional guidelines.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug