RESOLVED FIXED 117027
Separate generic font family settings to a class 
https://bugs.webkit.org/show_bug.cgi?id=117027
Summary Separate generic font family settings to a class
Antti Koivisto
Reported 2013-05-30 06:56:37 PDT
The class will be under platform/ and accessed by the font code directly without platform violations.
Attachments
patch (28.70 KB, patch)
2013-05-30 07:10 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-05-30 07:10:04 PDT
Created attachment 203354 [details] patch
WebKit Commit Bot
Comment 2 2013-05-30 07:12:38 PDT
Attachment 203354 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', u'Source/WebCore/platform/graphics/FontGenericFamilies.cpp', u'Source/WebCore/platform/graphics/FontGenericFamilies.h']" exit_code: 1 Source/WebCore/page/Settings.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 3 2013-05-30 07:21:01 PDT
Comment on attachment 203354 [details] patch Ok.
Ahmad Saleem
Comment 4 2022-10-05 16:27:53 PDT
This seems to have landed in this commit and not backed out: https://github.com/WebKit/WebKit/commit/73904e2b793c6133dd518895db0e6c091803da66 Marking this as "RESOLVED FIXED". Thanks!
Note You need to log in before you can comment on or make changes to this bug.