Bug 117027 - Separate generic font family settings to a class
Summary: Separate generic font family settings to a class
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-30 06:56 PDT by Antti Koivisto
Modified: 2022-10-05 16:27 PDT (History)
5 users (show)

See Also:


Attachments
patch (28.70 KB, patch)
2013-05-30 07:10 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-05-30 06:56:37 PDT
The class will be under platform/ and accessed by the font code directly without platform violations.
Comment 1 Antti Koivisto 2013-05-30 07:10:04 PDT
Created attachment 203354 [details]
patch
Comment 2 WebKit Commit Bot 2013-05-30 07:12:38 PDT
Attachment 203354 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/CMakeLists.txt', u'Source/WebCore/ChangeLog', u'Source/WebCore/GNUmakefile.list.am', u'Source/WebCore/Target.pri', u'Source/WebCore/WebCore.vcproj/WebCore.vcproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj', u'Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters', u'Source/WebCore/WebCore.xcodeproj/project.pbxproj', u'Source/WebCore/page/Settings.cpp', u'Source/WebCore/page/Settings.h', u'Source/WebCore/platform/graphics/FontGenericFamilies.cpp', u'Source/WebCore/platform/graphics/FontGenericFamilies.h']" exit_code: 1
Source/WebCore/page/Settings.h:44:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-05-30 07:21:01 PDT
Comment on attachment 203354 [details]
patch

Ok.
Comment 4 Ahmad Saleem 2022-10-05 16:27:53 PDT
This seems to have landed in this commit and not backed out:

https://github.com/WebKit/WebKit/commit/73904e2b793c6133dd518895db0e6c091803da66

Marking this as "RESOLVED FIXED". Thanks!