Bug 117023 - Update XMLHttpRequest timeout tests to a newer version from W3C
Summary: Update XMLHttpRequest timeout tests to a newer version from W3C
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords:
Depends on:
Blocks: 116983
  Show dependency tree / graph
 
Reported: 2013-05-30 03:01 PDT by Zan Dobersek
Modified: 2013-05-30 11:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (33.37 KB, patch)
2013-05-30 03:07 PDT, Zan Dobersek 		ap: review+
ap: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2013-05-30 03:01:01 PDT 
[Layout Tests] Update the XMLHttpRequest Timeout tests
Comment 1 Zan Dobersek 2013-05-30 03:07:39 PDT 
Created attachment 203333 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-05-30 10:42:04 PDT 
Comment on attachment 203333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203333&action=review

rs=me

> LayoutTests/ChangeLog:3
> +        [Layout Tests] Update the XMLHttpRequest Timeout tests

Please update the title when landing.

> LayoutTests/ChangeLog:20
> +        * http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.html: Copied from LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html.

Is this expected?

> LayoutTests/ChangeLog:34
> +        * http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides.html: Copied from LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html.

Is this expected?
Comment 3 Zan Dobersek 2013-05-30 11:13:20 PDT 
Comment on attachment 203333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=203333&action=review

Thanks for reviewing.

>> LayoutTests/ChangeLog:3
>> +        [Layout Tests] Update the XMLHttpRequest Timeout tests
> 
> Please update the title when landing.

Will do.

>> LayoutTests/ChangeLog:20
>> +        * http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.html: Copied from LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html.
> 
> Is this expected?

No, git actually registers new file additions that are similar enough to already existing files as copies. I'll just mark the file as added before landing.

>> LayoutTests/ChangeLog:34
>> +        * http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides.html: Copied from LayoutTests/http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html.
> 
> Is this expected?

Same as above.
Comment 4 Zan Dobersek 2013-05-30 11:34:48 PDT 
Committed r150973: <http://trac.webkit.org/changeset/150973>